Merge pull request #370 from microsoftgraph/code-coverage

Unit tests restructuring

Author: nikithauc

.gitignore

@@ -14,16 +14,11 @@ npm-debug.log
 /lib/*
 !/lib/.npmignore
 
-src/**/*.js
-src/**/*.js.map
-src/**/*.d.ts
-
 samples/node/secrets.json
 samples/browser/src/secrets.js
 samples/browser/src/graph-js-sdk.js
 samples/browser/src/graph-es-sdk.js
 
-spec/**/*.js
-spec/**/*.d.ts
-spec/**/*.js.map
-spec/**/secrets.ts
+test/development/secrets.ts
+
+.nyc_output/*

.prettierignore

@@ -6,6 +6,6 @@ src/**/*.js
 src/**/*.js.map
 src/**/*.d.ts
 
-spec/**/*.js
-spec/**/*.js.map
-spec/**/*.d.ts
+test/**/*.js
+test/**/*.js.map
+test/**/*.d.ts

.vscode/launch.json

@@ -18,7 +18,7 @@
 			"request": "launch",
 			"name": "Run Content tests",
 			"program": "${workspaceRoot}/node_modules/mocha/bin/_mocha",
-			"args": ["${workspaceRoot}/lib/spec/content/*.js"],
+			"args": ["${workspaceRoot}/lib/test/common/**/*.js"],
 			"cwd": "${workspaceRoot}",
 			"preLaunchTask": "Run Compile",
 			"outFiles": [],
@@ -29,7 +29,7 @@
 			"request": "launch",
 			"name": "Run Core tests",
 			"program": "${workspaceRoot}/node_modules/mocha/bin/_mocha",
-			"args": ["${workspaceRoot}/lib/spec/core/*.js"],
+			"args": ["${workspaceRoot}/lib/test/common/core/*.js"],
 			"cwd": "${workspaceRoot}",
 			"preLaunchTask": "Run Compile",
 			"outFiles": [],
@@ -40,7 +40,7 @@
 			"request": "launch",
 			"name": "Run Middleware tests",
 			"program": "${workspaceRoot}/node_modules/mocha/bin/_mocha",
-			"args": ["${workspaceRoot}/lib/spec/middleware/*.js"],
+			"args": ["${workspaceRoot}/lib/test/common/middleware/*.js"],
 			"cwd": "${workspaceRoot}",
 			"preLaunchTask": "Run Compile",
 			"outFiles": [],
@@ -51,7 +51,7 @@
 			"request": "launch",
 			"name": "Run Tasks tests",
 			"program": "${workspaceRoot}/node_modules/mocha/bin/_mocha",
-			"args": ["${workspaceRoot}/lib/spec/tasks/*.js"],
+			"args": ["${workspaceRoot}/lib/test/common/tasks/*.js"],
 			"cwd": "${workspaceRoot}",
 			"preLaunchTask": "Run Compile",
 			"outFiles": [],
@@ -62,7 +62,7 @@
 			"request": "launch",
 			"name": "Run Workload tests",
 			"program": "${workspaceRoot}/node_modules/mocha/bin/_mocha",
-			"args": ["${workspaceRoot}/spec/development/workload/*.js"],
+			"args": ["${workspaceRoot}/test/common/development/workload/*.js"],
 			"cwd": "${workspaceRoot}",
 			"preLaunchTask": "Run Compile",
 			"outFiles": [],

CONTRIBUTING.md

@@ -114,10 +114,9 @@ npm install
 
 To edit files, open them in an editor of your choice and modify them. To create a new file, use the editor of your choice and save the new file in the appropriate location in your local copy of the repository. While working, save your work frequently.
 
-*Note: Make sure to add unit tests to validate you changes.*
+_Note: Make sure to add unit tests to validate you changes._
 
-Once you have done with your changes, You have to build and test your changes
-To build the library run,
+Build and test your changes with the following commands after you have completed your work:
 
 ```cmd
 npm run build

README.md

@@ -68,7 +68,6 @@ Refer devDependencies in [package.json](./package.json) for the compatible msal
 ```
 
 ```typescript
-
 // Configuration options for MSAL @see https://github.com/AzureAD/microsoft-authentication-library-for-js/wiki/MSAL.js-1.0.0-api-release#configuration-options
 const msalConfig = {
 	auth: {
@@ -97,7 +96,7 @@ npm install msal@<version>
 import { UserAgentApplication } from "msal";
 
 import { ImplicitMSALAuthenticationProvider } from "@microsoft/microsoft-graph-client/lib/src/ImplicitMSALAuthenticationProvider";
-import { MSALAuthenticationProviderOptions } from '@microsoft/microsoft-graph-client/lib/src/MSALAuthenticationProviderOptions';
+import { MSALAuthenticationProviderOptions } from "@microsoft/microsoft-graph-client/lib/src/MSALAuthenticationProviderOptions";
 
 // An Optional options for initializing the MSAL @see https://github.com/AzureAD/microsoft-authentication-library-for-js/wiki/MSAL-basics#configuration-options
 const msalConfig = {

karma.conf.js

@@ -0,0 +1,13 @@
+module.exports = function(config) {
+    config.set({
+        frameworks: ["mocha", "chai", "karma-typescript"],
+        files: ["test/common/**/*.ts", "src/**/*.ts", "test/browser/**/*.ts", "test/*.ts"],
+        preprocessors: {
+            "**/*.ts": ["karma-typescript"],
+        },
+        karmaTypescriptConfig: {
+            tsconfig: "./tsconfig-cjs.json",
+        },
+        browsers: ["ChromeHeadless"],
+    });
+};

lib/.npmignore

@@ -1,2 +1,2 @@
 .npmignore
-spec/
+test/