Skip to content

createWithMiddleware method in HttpClientFactory is not public #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
darrelmiller opened this issue Feb 5, 2019 · 2 comments
Closed

createWithMiddleware method in HttpClientFactory is not public #140

darrelmiller opened this issue Feb 5, 2019 · 2 comments

Comments

@darrelmiller
Copy link
Contributor

msgraph-sdk-javascript/src/HTTPClientFactory.ts

Line 45 in 1ccd751

static createWithMiddleware(middleware: Middleware): HTTPClient {

In the comments it says it should be public. Which is correct?
@muthurathinam
Copy link
Contributor

@darrelmiller
Actually, the access specifier for a member of a class defaults to public. So the createWithMiddleware is public.

Was adding public for more readability and missed with this method. Fix will be merged with the PR from Linter_and_Prettier branch.

@muthurathinam
Copy link
Contributor

Fixed in v1.5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@darrelmiller @muthurathinam