Skip to content

Update design for task classes like LargeFileTaskUpload and PageIterator task. #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nikithauc opened this issue Jan 19, 2021 · 2 comments
Assignees

Comments

@nikithauc
Copy link
Contributor

nikithauc commented Jan 19, 2021

Currently, when creating the LargeFileUpload object or the PageIterator object, we are passing a Client object which is used to make the requests.
The current design creates limitations in customizing the GraphRequest object options.
Example - To pass custom headers in the PageIterator, we pass a requestOptions parameter while creating the PageIterator object.
Another problem I came across was when working on #359. The response format of Outlook and OneDrive are different and I need to customize the ResponseType in the GraphRequest object.

Related to - microsoftgraph/msgraph-sdk-design#37

The design of the task classes should be updated to allow easy customizations and changeability. The relations between the classes can be reengineered. Example - use a behavioral design pattern.

AB#7642

@ghost ghost added the ToTriage label Jan 19, 2021
@nikithauc nikithauc self-assigned this Jan 19, 2021
@ghost ghost removed the ToTriage label Jan 19, 2021
@nikithauc
Copy link
Contributor Author

To be considered with #500 and #499

@ddyett
Copy link
Contributor

ddyett commented Jul 25, 2023

tracked now in sdk design

@ddyett ddyett closed this as completed Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants