Skip to content

Bug - LargeFileUploadTask will not report 100% upload progress #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 of 6 tasks
ChikyChan opened this issue Aug 8, 2022 · 2 comments · Fixed by #916
Closed
5 of 6 tasks

Bug - LargeFileUploadTask will not report 100% upload progress #915

ChikyChan opened this issue Aug 8, 2022 · 2 comments · Fixed by #916
Assignees

Comments

@ChikyChan
Copy link

Bug Report

Prerequisites

  • Can you reproduce the problem?
  • Are you running the latest version?
  • Are you reporting to the correct repository?
  • Did you perform a cursory search?

For more information, see the CONTRIBUTING guide.

Description

[Description of the bug or feature]

I was following the Upload large files using the Microsoft Graph SDKs sample to implement file upload function, and when I use this implemented function to file upload, I found that the uploadEventHandlers.progress will not be triggered while the last slice uploaded.

I checked the source code, found that if the last slice uploaded, Graph API will respond the driveItem information with 201 Created status code, and in source code, if Graph API return 201, it will return the response immediately.

Console Errors: None

Screenshots: [If applicable, add screenshots to help explain your problem]
The network requests
Network requests

LargeFileUplaodTask source code
LargeFileUploadTask.ts
Source Code

Steps to Reproduce

  1. Follow the steps Upload large files using the Microsoft Graph SDKs
  2. Login my application and proceed file upload.

Expected behavior:
LargeFileUploadTask report 100% after file upload finished

Actual behavior:
LargeFileUploadTask will not report 100% after file upload finished, like dotnet client did.

Additional Context

Add any other context about the problem here..

Usage Information

Request ID - Value of the requestId field if you are receiving a Graph API error response
None

SDK Version - [SDK version you are using] 3.0.2

  • Node (Check, if using Node version of SDK)

Node Version - [The version of Node you are using]

  • Browser (Check, if using Browser version of SDK)

Browser Name - [The name of Browser that you are using for SDK]
Edge

Version - [The version of the browser you are using]
Version 104.0.1293.47 (Official build) (64-bit)

@ghost ghost added the ToTriage label Aug 8, 2022
@rkodev rkodev self-assigned this Aug 8, 2022
@ghost ghost removed the ToTriage label Aug 8, 2022
@rkodev
Copy link
Contributor

rkodev commented Aug 8, 2022

Hi @ChikyChan thanks for reporting this.

This issue is currently being looked at and will be updated accordingly when fixed.

@nikithauc
Copy link
Contributor

Fix released in 3.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants