Skip to content

Documentation - add links to JS samples #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2021
Merged

Conversation

nikithauc
Copy link
Contributor

Fixes #470

Copy link
Contributor

@MIchaelMainer MIchaelMainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sendUsersMail image and link is a bit off. Should probably be in a section about typings.

Also, there are duplicate links to samples and tutorials at the bottom of the document. Perhaps that is a good thing, it is nice to find the links in the TOC.

@nikithauc
Copy link
Contributor Author

The sendUsersMail image and link is a bit off. Should probably be in a section about typings.

Also, there are duplicate links to samples and tutorials at the bottom of the document. Perhaps that is a good thing, it is nice to find the links in the TOC.

@MIchaelMainer can you explain what should be the correction be for the sendUsersMail image and link?

The duplicate links in the TOC and the samples sections are intentional.

@MIchaelMainer
Copy link
Contributor

@nikithauc The sendUsersMail image and link occur in the same section as that TOC/Navigation section. There should a section and description that describe what the image is and why the customer should follow it.

Perhaps something like:

TypeScript

This client library is supported with typings that represent the objects in Microsoft Graph. We provide typing support for the v1.0 and beta models.

TypeScript demo

@nikithauc
Copy link
Contributor Author

@nikithauc The sendUsersMail image and link occur in the same section as that TOC/Navigation section. There should a section and description that describe what the image is and why the customer should follow it.

Perhaps something like:

TypeScript

This client library is supported with typings that represent the objects in Microsoft Graph. We provide typing support for the v1.0 and beta models.

TypeScript demo
Done!

@nikithauc nikithauc merged commit c2fe947 into dev Jun 18, 2021
@nikithauc nikithauc deleted the documentation/sample-links branch June 18, 2021 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for using Graph SDK with MSAL.js
3 participants