Skip to content

Add testExistsRelationshipWhereClauseParsing() unit test. #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mikebronner opened this issue Oct 12, 2017 · 3 comments
Closed

Add testExistsRelationshipWhereClauseParsing() unit test. #15

mikebronner opened this issue Oct 12, 2017 · 3 comments

Comments

@mikebronner
Copy link
Owner

Code is already in place, all you need to do is add the test. :)

@brunorsantos
Copy link
Contributor

#22

@brunorsantos
Copy link
Contributor

Hi! implementing this test, I realized that does not exists an implementation for caching a query for Relationship Absence. It would be when we try to do something like:

$authors = collect([(new Author)->doesntHave('books')->first()]);

I tried to execute it, and it returns an error when trying to create a cache key:

ErrorException: Undefined index: column

/home/vagrant/Code/laravel-model-caching/src/CachedBuilder.php:106
/home/vagrant/Code/laravel-model-caching/vendor/laravel/framework/src/Illuminate/Support/Collection.php:1197
/home/vagrant/Code/laravel-model-caching/src/CachedBuilder.php:107
/home/vagrant/Code/laravel-model-caching/src/CachedBuilder.php:28
/home/vagrant/Code/laravel-model-caching/src/CachedBuilder.php:203

Can I open an issue for this?
Thanks

@mikebronner
Copy link
Owner Author

@brunosantos thanks for reporting, yes, please create an issue! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants