Skip to content

Commit 1a37c24

Browse files
committed
Upgrade to react 16.9 in dev to prevent act warning in tests
facebook/react#14769
1 parent b96f8be commit 1a37c24

File tree

5 files changed

+17
-26
lines changed

5 files changed

+17
-26
lines changed

Diff for: __tests__/Drag.test.js

-3
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@ import 'jest-dom/extend-expect'
44
import Interactive from './components/Interactive'
55
import InteractiveDom from './components/InteractiveDom'
66

7-
// TODO - fix act warning (probably caused by RAF in cancel)
8-
// https://github.com/facebook/react/issues/14769
9-
107
// TODO - test drag with touch events
118
// TODO - test with pointerEvents
129

Diff for: __tests__/Move.test.js

-3
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@ import InteractiveDom from './components/InteractiveDom'
66

77
afterAll(cleanup)
88

9-
// TODO - fix act warning (probably caused by debounce)
10-
// https://github.com/facebook/react/issues/14769
11-
129
describe.each([['attached to component', Interactive, false], ['attached to node', InteractiveDom, true]])(
1310
'testing onMove %s)',
1411
(testName, Component, domTarget) => {

Diff for: __tests__/Scroll.test.js

-3
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@ import 'jest-dom/extend-expect'
44
import Interactive from './components/Interactive'
55
import InteractiveDom from './components/InteractiveDom'
66

7-
// TODO - fix act warning (probably caused by debounce)
8-
// https://github.com/facebook/react/issues/14769
9-
107
afterAll(cleanup)
118

129
describe.each([['attached to component', Interactive, false], ['attached to node', InteractiveDom, true]])(

Diff for: package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"build": "rollup -c",
1717
"prepare": "npm run build",
1818
"test": "jest",
19-
"test:watch": "jest --watch --silent",
19+
"test:watch": "jest --watch",
2020
"test:coverage": "jest --coverage --silent",
2121
"dtslint": "dtslint types"
2222
},
@@ -67,8 +67,8 @@
6767
"jest-dom": "^3.1.3",
6868
"prettier": "^1.16.4",
6969
"pretty-quick": "^1.10.0",
70-
"react": "^16.8.0",
71-
"react-dom": "^16.8.0",
70+
"react": "^16.9.0-alpha.0",
71+
"react-dom": "^16.9.0-alpha.0",
7272
"react-testing-library": "^7.0.0",
7373
"rimraf": "^2.6.2",
7474
"rollup": "^1.10.0",

Diff for: yarn.lock

+14-14
Original file line numberDiff line numberDiff line change
@@ -4227,15 +4227,15 @@ rc@^1.2.7:
42274227
minimist "^1.2.0"
42284228
strip-json-comments "~2.0.1"
42294229

4230-
react-dom@^16.8.0:
4231-
version "16.8.6"
4232-
resolved "https://registry.yarnpkg.com/react-dom/-/react-dom-16.8.6.tgz#71d6303f631e8b0097f56165ef608f051ff6e10f"
4233-
integrity sha512-1nL7PIq9LTL3fthPqwkvr2zY7phIPjYrT0jp4HjyEQrEROnw4dG41VVwi/wfoCneoleqrNX7iAD+pXebJZwrwA==
4230+
react-dom@^16.9.0-alpha.0:
4231+
version "16.9.0-alpha.0"
4232+
resolved "https://registry.yarnpkg.com/react-dom/-/react-dom-16.9.0-alpha.0.tgz#9dfaec18ac1a500fa72cab7b70f2ae29d0cd7716"
4233+
integrity sha512-BQ5gN42yIPuTnBvE6K9vSjNfDRpSNcYCs2sUx9XR5VaWKwlHTt3G6qIWK6zdXy8TYKb1+IxpsAI0RtbRdXQZ2A==
42344234
dependencies:
42354235
loose-envify "^1.1.0"
42364236
object-assign "^4.1.1"
42374237
prop-types "^15.6.2"
4238-
scheduler "^0.13.6"
4238+
scheduler "^0.14.0-alpha.0"
42394239

42404240
react-is@^16.8.1, react-is@^16.8.4:
42414241
version "16.8.6"
@@ -4250,15 +4250,15 @@ react-testing-library@^7.0.0:
42504250
"@babel/runtime" "^7.4.3"
42514251
dom-testing-library "^4.0.0"
42524252

4253-
react@^16.8.0:
4254-
version "16.8.6"
4255-
resolved "https://registry.yarnpkg.com/react/-/react-16.8.6.tgz#ad6c3a9614fd3a4e9ef51117f54d888da01f2bbe"
4256-
integrity sha512-pC0uMkhLaHm11ZSJULfOBqV4tIZkx87ZLvbbQYunNixAAvjnC+snJCg0XQXn9VIsttVsbZP/H/ewzgsd5fxKXw==
4253+
react@^16.9.0-alpha.0:
4254+
version "16.9.0-alpha.0"
4255+
resolved "https://registry.yarnpkg.com/react/-/react-16.9.0-alpha.0.tgz#e350f3d8af36e3251079cbc90d304620e2f78ccb"
4256+
integrity sha512-y4bu7rJvtnPPsIwOj7sp5Y2SqlOb0jFupfkdjWxxn8ZeqzUARgpR9wJBUVwW1/QosVdOblmApjo/j6iiAXnebA==
42574257
dependencies:
42584258
loose-envify "^1.1.0"
42594259
object-assign "^4.1.1"
42604260
prop-types "^15.6.2"
4261-
scheduler "^0.13.6"
4261+
scheduler "^0.14.0-alpha.0"
42624262

42634263
read-pkg-up@^2.0.0:
42644264
version "2.0.0"
@@ -4610,10 +4610,10 @@ sax@^1.2.4:
46104610
resolved "https://registry.yarnpkg.com/sax/-/sax-1.2.4.tgz#2816234e2378bddc4e5354fab5caa895df7100d9"
46114611
integrity sha512-NqVDv9TpANUjFm0N8uM5GxL36UgKi9/atZw+x7YFnQ8ckwFGKrl4xX4yWtrey3UJm5nP1kUbnYgLopqWNSRhWw==
46124612

4613-
scheduler@^0.13.6:
4614-
version "0.13.6"
4615-
resolved "https://registry.yarnpkg.com/scheduler/-/scheduler-0.13.6.tgz#466a4ec332467b31a91b9bf74e5347072e4cd889"
4616-
integrity sha512-IWnObHt413ucAYKsD9J1QShUKkbKLQQHdxRyw73sw4FN26iWr3DY/H34xGPe4nmL1DwXyWmSWmMrA9TfQbE/XQ==
4613+
scheduler@^0.14.0-alpha.0:
4614+
version "0.14.0"
4615+
resolved "https://registry.yarnpkg.com/scheduler/-/scheduler-0.14.0.tgz#b392c23c9c14bfa2933d4740ad5603cc0d59ea5b"
4616+
integrity sha512-9CgbS06Kki2f4R9FjLSITjZo5BZxPsryiRNyL3LpvrM9WxcVmhlqAOc9E+KQbeI2nqej4JIIbOsfdL51cNb4Iw==
46174617
dependencies:
46184618
loose-envify "^1.1.0"
46194619
object-assign "^4.1.1"

0 commit comments

Comments
 (0)