Skip to content
This repository was archived by the owner on Jul 18, 2018. It is now read-only.

Commit 250263f

Browse files
wwwillchenCommit bot
authored and
Commit bot
committed
DevTools: fix npm_test architecture check
process.arch is based on the architecture which node.js was compiled for, not necessarily the architecture of the system the node.js process is currently running in. I came across this issue while working on buildbot related stuff. More info: nodejs/node-v0.x-archive#2862 BUG=none Review-Url: https://codereview.chromium.org/2698983004 Cr-Commit-Position: refs/heads/master@{#451511}
1 parent dfb5d07 commit 250263f

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

third_party/WebKit/Source/devtools/scripts/npm_test.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -145,14 +145,10 @@ function copyFrontend(contentShellResourcesPath) {
145145

146146
function getPlatform() {
147147
if (process.platform === 'linux') {
148-
if (process.arch === 'x64')
149-
return 'Linux_x64';
150-
throw new Error('Pre-compiled content shells are only available for x64 on Linux');
148+
return 'Linux_x64';
151149
}
152150
if (process.platform === 'win32') {
153-
if (process.arch === 'x64')
154-
return 'Win_x64';
155-
return 'Win';
151+
return 'Win_x64';
156152
}
157153
if (process.platform === 'darwin')
158154
return 'Mac';

0 commit comments

Comments
 (0)