Skip to content

Commit e4a082f

Browse files
dschomjcheetham
authored andcommitted
Merge virtualfilesystem hook
Add virtual file system settings and hook proc. On index load, clear/set the skip worktree bits based on the virtual file system data. Use virtual file system data to update skip-worktree bit in unpack-trees. Use virtual file system data to exclude files and folders not explicitly requested. The hook was first contributed in private, but was extended via the following pull requests: git-for-windows#15 git-for-windows#27 git-for-windows#33 git-for-windows#70 Signed-off-by: Ben Peart <[email protected]> Signed-off-by: Derrick Stolee <[email protected]>
2 parents 4f56030 + 0078286 commit e4a082f

18 files changed

+876
-7
lines changed

Documentation/config/core.txt

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,14 @@ Version 2 uses an opaque string so that the monitor can return
111111
something that can be used to determine what files have changed
112112
without race conditions.
113113

114+
core.virtualFilesystem::
115+
If set, the value of this variable is used as a command which
116+
will identify all files and directories that are present in
117+
the working directory. Git will only track and update files
118+
listed in the virtual file system. Using the virtual file system
119+
will supersede the sparse-checkout settings which will be ignored.
120+
See the "virtual file system" section of linkgit:githooks[5].
121+
114122
core.trustctime::
115123
If false, the ctime differences between the index and the
116124
working tree are ignored; useful when the inode change time

Documentation/githooks.txt

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -698,6 +698,26 @@ and "0" meaning they were not.
698698
Only one parameter should be set to "1" when the hook runs. The hook
699699
running passing "1", "1" should not be possible.
700700

701+
virtualFilesystem
702+
~~~~~~~~~~~~~~~~~~
703+
704+
"Virtual File System" allows populating the working directory sparsely.
705+
The projection data is typically automatically generated by an external
706+
process. Git will limit what files it checks for changes as well as which
707+
directories are checked for untracked files based on the path names given.
708+
Git will also only update those files listed in the projection.
709+
710+
The hook is invoked when the configuration option core.virtualFilesystem
711+
is set. It takes one argument, a version (currently 1).
712+
713+
The hook should output to stdout the list of all files in the working
714+
directory that git should track. The paths are relative to the root
715+
of the working directory and are separated by a single NUL. Full paths
716+
('dir1/a.txt') as well as directories are supported (ie 'dir1/').
717+
718+
The exit status determines whether git will use the data from the
719+
hook. On error, git will abort the command with an error message.
720+
701721
SEE ALSO
702722
--------
703723
linkgit:git-hook[1]

Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1107,6 +1107,7 @@ LIB_OBJS += utf8.o
11071107
LIB_OBJS += varint.o
11081108
LIB_OBJS += version.o
11091109
LIB_OBJS += versioncmp.o
1110+
LIB_OBJS += virtualfilesystem.o
11101111
LIB_OBJS += walker.o
11111112
LIB_OBJS += wildmatch.o
11121113
LIB_OBJS += worktree.o

cache.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1067,6 +1067,7 @@ enum fsync_method {
10671067

10681068
extern enum fsync_method fsync_method;
10691069
extern int core_preload_index;
1070+
extern const char *core_virtualfilesystem;
10701071
extern int core_gvfs;
10711072
extern int precomposed_unicode;
10721073
extern int protect_hfs;

config.c

Lines changed: 43 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1724,7 +1724,11 @@ int git_default_core_config(const char *var, const char *value, void *cb)
17241724
}
17251725

17261726
if (!strcmp(var, "core.sparsecheckout")) {
1727-
core_apply_sparse_checkout = git_config_bool(var, value);
1727+
/* virtual file system relies on the sparse checkout logic so force it on */
1728+
if (core_virtualfilesystem)
1729+
core_apply_sparse_checkout = 1;
1730+
else
1731+
core_apply_sparse_checkout = git_config_bool(var, value);
17281732
return 0;
17291733
}
17301734

@@ -2751,6 +2755,44 @@ int git_config_get_max_percent_split_change(void)
27512755
return -1; /* default value */
27522756
}
27532757

2758+
int git_config_get_virtualfilesystem(void)
2759+
{
2760+
/* Run only once. */
2761+
static int virtual_filesystem_result = -1;
2762+
if (virtual_filesystem_result >= 0)
2763+
return virtual_filesystem_result;
2764+
2765+
if (git_config_get_pathname("core.virtualfilesystem", &core_virtualfilesystem))
2766+
core_virtualfilesystem = getenv("GIT_VIRTUALFILESYSTEM_TEST");
2767+
2768+
if (core_virtualfilesystem && !*core_virtualfilesystem)
2769+
core_virtualfilesystem = NULL;
2770+
2771+
if (core_virtualfilesystem) {
2772+
/*
2773+
* Some git commands spawn helpers and redirect the index to a different
2774+
* location. These include "difftool -d" and the sequencer
2775+
* (i.e. `git rebase -i`, `git cherry-pick` and `git revert`) and others.
2776+
* In those instances we don't want to update their temporary index with
2777+
* our virtualization data.
2778+
*/
2779+
char *default_index_file = xstrfmt("%s/%s", the_repository->gitdir, "index");
2780+
int should_run_hook = !strcmp(default_index_file, the_repository->index_file);
2781+
2782+
free(default_index_file);
2783+
if (should_run_hook) {
2784+
/* virtual file system relies on the sparse checkout logic so force it on */
2785+
core_apply_sparse_checkout = 1;
2786+
virtual_filesystem_result = 1;
2787+
return 1;
2788+
}
2789+
core_virtualfilesystem = NULL;
2790+
}
2791+
2792+
virtual_filesystem_result = 0;
2793+
return 0;
2794+
}
2795+
27542796
int git_config_get_index_threads(int *dest)
27552797
{
27562798
int is_bool, val;

config.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -598,6 +598,7 @@ int git_config_get_pathname(const char *key, const char **dest);
598598
int git_config_get_index_threads(int *dest);
599599
int git_config_get_split_index(void);
600600
int git_config_get_max_percent_split_change(void);
601+
int git_config_get_virtualfilesystem(void);
601602

602603
/* This dies if the configured or default date is in the future */
603604
int git_config_get_expiry(const char *key, const char **output);

dir.c

Lines changed: 30 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
* Junio Hamano, 2005-2006
77
*/
88
#include "cache.h"
9+
#include "virtualfilesystem.h"
910
#include "config.h"
1011
#include "dir.h"
1112
#include "object-store.h"
@@ -1416,6 +1417,17 @@ enum pattern_match_result path_matches_pattern_list(
14161417
int result = NOT_MATCHED;
14171418
size_t slash_pos;
14181419

1420+
/*
1421+
* The virtual file system data is used to prevent git from traversing
1422+
* any part of the tree that is not in the virtual file system. Return
1423+
* 1 to exclude the entry if it is not found in the virtual file system,
1424+
* else fall through to the regular excludes logic as it may further exclude.
1425+
*/
1426+
if (*dtype == DT_UNKNOWN)
1427+
*dtype = resolve_dtype(DT_UNKNOWN, istate, pathname, pathlen);
1428+
if (is_excluded_from_virtualfilesystem(pathname, pathlen, *dtype) > 0)
1429+
return 1;
1430+
14191431
if (!pl->use_cone_patterns) {
14201432
pattern = last_matching_pattern_from_list(pathname, pathlen, basename,
14211433
dtype, pl, istate);
@@ -1759,8 +1771,20 @@ struct path_pattern *last_matching_pattern(struct dir_struct *dir,
17591771
int is_excluded(struct dir_struct *dir, struct index_state *istate,
17601772
const char *pathname, int *dtype_p)
17611773
{
1762-
struct path_pattern *pattern =
1763-
last_matching_pattern(dir, istate, pathname, dtype_p);
1774+
struct path_pattern *pattern;
1775+
1776+
/*
1777+
* The virtual file system data is used to prevent git from traversing
1778+
* any part of the tree that is not in the virtual file system. Return
1779+
* 1 to exclude the entry if it is not found in the virtual file system,
1780+
* else fall through to the regular excludes logic as it may further exclude.
1781+
*/
1782+
if (*dtype_p == DT_UNKNOWN)
1783+
*dtype_p = resolve_dtype(DT_UNKNOWN, istate, pathname, strlen(pathname));
1784+
if (is_excluded_from_virtualfilesystem(pathname, strlen(pathname), *dtype_p) > 0)
1785+
return 1;
1786+
1787+
pattern = last_matching_pattern(dir, istate, pathname, dtype_p);
17641788
if (pattern)
17651789
return pattern->flags & PATTERN_FLAG_NEGATIVE ? 0 : 1;
17661790
return 0;
@@ -2325,6 +2349,8 @@ static enum path_treatment treat_path(struct dir_struct *dir,
23252349
ignore_case);
23262350
if (dtype != DT_DIR && has_path_in_index)
23272351
return path_none;
2352+
if (is_excluded_from_virtualfilesystem(path->buf, path->len, dtype) > 0)
2353+
return path_excluded;
23282354

23292355
/*
23302356
* When we are looking at a directory P in the working tree,
@@ -2529,6 +2555,8 @@ static void add_path_to_appropriate_result_list(struct dir_struct *dir,
25292555
/* add the path to the appropriate result list */
25302556
switch (state) {
25312557
case path_excluded:
2558+
if (is_excluded_from_virtualfilesystem(path->buf, path->len, DT_DIR) > 0)
2559+
break;
25322560
if (dir->flags & DIR_SHOW_IGNORED)
25332561
dir_add_name(dir, istate, path->buf, path->len);
25342562
else if ((dir->flags & DIR_SHOW_IGNORED_TOO) ||

environment.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ int core_apply_sparse_checkout;
7474
int core_sparse_checkout_cone;
7575
int sparse_expect_files_outside_of_patterns;
7676
int core_gvfs;
77+
const char *core_virtualfilesystem;
7778
int merge_log_config = -1;
7879
int precomposed_unicode = -1; /* see probe_utf8_pathname_composition() */
7980
unsigned long pack_size_limit_cfg;

hook.c

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,10 +179,22 @@ int run_hooks_opt(const char *hook_name, struct run_hooks_opt *options)
179179
.hook_name = hook_name,
180180
.options = options,
181181
};
182-
const char *const hook_path = find_hook(hook_name);
182+
const char *hook_path = find_hook(hook_name);
183183
int jobs = 1;
184184
int ret = 0;
185185

186+
/*
187+
* Backwards compatibility hack in VFS for Git: when originally
188+
* introduced (and used!), it was called `post-indexchanged`, but this
189+
* name was changed during the review on the Git mailing list.
190+
*
191+
* Therefore, when the `post-index-change` hook is not found, let's
192+
* look for a hook with the old name (which would be found in case of
193+
* already-existing checkouts).
194+
*/
195+
if (!hook_path && !strcmp(hook_name, "post-index-change"))
196+
hook_path = find_hook("post-indexchanged");
197+
186198
if (!options)
187199
BUG("a struct run_hooks_opt must be provided to run_hooks");
188200

read-cache.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
*/
66
#include "cache.h"
77
#include "gvfs.h"
8+
#include "virtualfilesystem.h"
89
#include "config.h"
910
#include "diff.h"
1011
#include "diffcore.h"
@@ -2042,6 +2043,7 @@ static void post_read_index_from(struct index_state *istate)
20422043
tweak_untracked_cache(istate);
20432044
tweak_split_index(istate);
20442045
tweak_fsmonitor(istate);
2046+
apply_virtualfilesystem(istate);
20452047
}
20462048

20472049
static size_t estimate_cache_size_from_compressed(unsigned int entries)

sparse-index.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -495,6 +495,7 @@ void clear_skip_worktree_from_present_files(struct index_state *istate)
495495
int i;
496496

497497
if (!core_apply_sparse_checkout ||
498+
core_virtualfilesystem ||
498499
sparse_expect_files_outside_of_patterns)
499500
return;
500501

t/t1090-sparse-checkout-scope.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,9 @@ test_expect_success 'in partial clone, sparse checkout only fetches needed blobs
104104
'
105105

106106
test_expect_success 'checkout does not delete items outside the sparse checkout file' '
107-
# The "sparse.expectfilesoutsideofpatterns" config will prevent the
107+
# The "core.virtualfilesystem" config will prevent the
108108
# SKIP_WORKTREE flag from being dropped on files present on-disk.
109-
test_config sparse.expectfilesoutsideofpatterns true &&
109+
test_config core.virtualfilesystem true &&
110110
111111
test_config core.gvfs 8 &&
112112
git checkout -b outside &&

0 commit comments

Comments
 (0)