package: fix usage of 'eslint-plugin-github'

Fix breakages introduced by the upgrade of the GitHub ESLint plugin from
v2.0.0 to v4.6.1. This upgrade involves a few breaking changes, namely the
removal of 'github/es6' (deprecated as of v4.0.0 [1]) in favor of
'github/recommended'. Update ESLint rules as 'actions/typescript-action' did
in a similar upgrade (see [2] and [3]).

Finally, run 'eslint --fix src/**/*.ts' to clean up any outstanding issues.

[1] https://github.com/github/eslint-plugin-github/releases/tag/v4.0.0-0
[2] actions/typescript-action#62
[3] actions/typescript-action@d3152badbbdc2

Signed-off-by: Victoria Dye <[email protected]>

Author: vdye

.eslintrc.json

@@ -1,13 +1,14 @@
 {
     "plugins": ["jest", "@typescript-eslint"],
-    "extends": ["plugin:github/es6"],
+    "extends": ["plugin:github/recommended"],
     "parser": "@typescript-eslint/parser",
     "parserOptions": {
       "ecmaVersion": 9,
       "sourceType": "module",
       "project": "./tsconfig.json"
     },
     "rules": {
+      "i18n-text/no-en": "off",
       "eslint-comments/no-use": "off",
       "import/no-namespace": "off",
       "no-unused-vars": "off",
@@ -16,13 +17,10 @@
       "@typescript-eslint/no-require-imports": "error",
       "@typescript-eslint/array-type": "error",
       "@typescript-eslint/await-thenable": "error",
-      "@typescript-eslint/ban-ts-ignore": "error",
+      "@typescript-eslint/ban-ts-comment": "error",
       "camelcase": "off",
-      "@typescript-eslint/camelcase": "error",
-      "@typescript-eslint/class-name-casing": "error",
       "@typescript-eslint/explicit-function-return-type": ["error", {"allowExpressions": true}],
       "@typescript-eslint/func-call-spacing": ["error", "never"],
-      "@typescript-eslint/generic-type-naming": ["error", "^[A-Z][A-Za-z]*$"],
       "@typescript-eslint/no-array-constructor": "error",
       "@typescript-eslint/no-empty-interface": "error",
       "@typescript-eslint/no-explicit-any": "error",
@@ -32,15 +30,14 @@
       "@typescript-eslint/no-misused-new": "error",
       "@typescript-eslint/no-namespace": "error",
       "@typescript-eslint/no-non-null-assertion": "warn",
-      "@typescript-eslint/no-object-literal-type-assertion": "error",
+      "@typescript-eslint/consistent-type-assertions": "error",
       "@typescript-eslint/no-unnecessary-qualifier": "error",
       "@typescript-eslint/no-unnecessary-type-assertion": "error",
       "@typescript-eslint/no-useless-constructor": "error",
       "@typescript-eslint/no-var-requires": "error",
       "@typescript-eslint/prefer-for-of": "warn",
       "@typescript-eslint/prefer-function-type": "warn",
       "@typescript-eslint/prefer-includes": "error",
-      "@typescript-eslint/prefer-interface": "error",
       "@typescript-eslint/prefer-string-starts-ends-with": "error",
       "@typescript-eslint/promise-function-async": "error",
       "@typescript-eslint/require-array-sort-compare": "error",
@@ -55,4 +52,4 @@
       "es6": true,
       "jest/globals": true
     }
-  }
+}

src/git.ts

@@ -104,9 +104,10 @@ export class Repository {
     );
   }
 
-  static splitRepoName(
-    ownerAndName: string
-  ): { owner: string; repoName: string } {
+  static splitRepoName(ownerAndName: string): {
+    owner: string;
+    repoName: string;
+  } {
     const nameParts = ownerAndName.split('/');
     if (nameParts.length !== 2) {
       throw new Error(`invalid repo name '${ownerAndName}'`);
@@ -127,8 +128,9 @@ export class Repository {
 
     assertOk(
       status,
-      `failed to download '${filePath}' @ '${branch ||
-        this.defaultBranch.name}' from '${this.owner}/${this.name}'`
+      `failed to download '${filePath}' @ '${
+        branch || this.defaultBranch.name
+      }' from '${this.owner}/${this.name}'`
     );
 
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
@@ -146,14 +148,15 @@ export class Repository {
     message: string,
     existingBlob?: string
   ): Promise<Commit> {
-    const { status, data } = await this.api.rest.repos.createOrUpdateFileContents({
-      ...this.req,
-      content: Buffer.from(content).toString('base64'),
-      branch,
-      path: filePath,
-      message,
-      sha: existingBlob
-    });
+    const { status, data } =
+      await this.api.rest.repos.createOrUpdateFileContents({
+        ...this.req,
+        content: Buffer.from(content).toString('base64'),
+        branch,
+        path: filePath,
+        message,
+        sha: existingBlob
+      });
 
     assertOk(
       status,

src/homebrew.ts

@@ -7,7 +7,6 @@ export class Package {
   readonly gitBlob: string | undefined;
   content: string;
 
-  /* eslint-disable no-dupe-class-members */
   constructor(gitFile: Git.File);
   constructor(filePath: string, content: string);
   constructor(pathOrGitFile: string | Git.File, content?: string) {
@@ -22,7 +21,6 @@ export class Package {
 
     this.originalContent = this.content;
   }
-  /* eslint-enable no-dupe-class-members */
 
   isDirty(): boolean {
     return this.originalContent !== this.content;
@@ -37,7 +35,7 @@ export class Package {
     return match ? match[3] : '';
   }
 
-  setField(name: string, value: string, instance: number = 0): void {
+  setField(name: string, value: string, instance = 0): void {
     let tracker = 0;
     this.content = this.content.replace(
       this.getFieldRegex(name),

src/main.ts

@@ -231,7 +231,7 @@ async function run(): Promise<void> {
     if (error instanceof Error) {
       core.setFailed(error);
     } else {
-      core.setFailed(`Unknown error occurred.`)
+      core.setFailed(`Unknown error occurred.`);
     }
   }
 }