-
Notifications
You must be signed in to change notification settings - Fork 77
Bump dependencies after version 0.24 #1105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Some dependencies need Rust 1.74 or newer, which does not comply with our MSRV 1.71.1. I don't think it is worth to bump MSRV for this reason. Maybe revert the dependency? |
The dependency is pulled in by criterion 0.5.1. |
Criterion depends on I don't see what new feature of Rust 1.74 Clap is using, but according to Clap's doc, it only intends to supports N-2 MSRV. So it may be bumping MSRV for no reason. While that's compatible with our N-1 MSRV policy, I don't think it's necessary for us to bump our |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I also removed dependencies on
There is one small problem. |
This PR updates Cargo crates dependencies and GitHub Actions dependencies after v0.24 was released, with two exceptions:
criterion
because a later version unintentionally requires MSRV 1.74. The problem has been fixed in the upstream criterion repo, but has not been released, yet.actions-rs/toolchain
with manual invocations ofrustup
becauseactions-rs/toolchain
is no longer maintained. For tasks that don't require a specific toolchain, we rely onrustup
andcargo
to automatically install the toolchain specified by the filerust-toolchain
upon first invocation.Also disabled Clippy checks on Darwin because the
clippy
program itself randomly crashes on Darwin.