Rename edge to slot (#171)

Parent PR: mmtk/mmtk-core#1134

---------

Co-authored-by: mmtkgc-bot <[email protected]>

Author: wks

jikesrvm/rvm/src/org/jikesrvm/mm/mminterface/RustScanThread.java

@@ -123,8 +123,8 @@
   private Address edges;
   private Word size = Word.zero();
   // The buffer size agreed between the Rust part and the Java part of the binding.
-  // See the constant EDGES_BUFFER_CAPACITY in scanning.rs.
-  public static final Word EDGES_BUFFER_CAPACITY = Word.fromIntZeroExtend(4096);
+  // See the constant SLOTS_BUFFER_CAPACITY in scanning.rs.
+  public static final Word SLOTS_BUFFER_CAPACITY = Word.fromIntZeroExtend(4096);
 
   /***********************************************************************
    *
@@ -222,7 +222,7 @@ private void reportEdge(Address edge) {
     if (VM.VerifyAssertions) VM._assert(!this.edges.isZero());
     this.edges.plus(cursor.toInt() << LOG_BYTES_IN_WORD).store(edge);
     // Flush if full
-    if (cursor.GE(EDGES_BUFFER_CAPACITY)) {
+    if (cursor.GE(SLOTS_BUFFER_CAPACITY)) {
       flush();
     }
   }

mmtk/Cargo.lock

@@ -16,7 +16,7 @@ lto = true
 [package.metadata.jikesrvm]
 # Our CI matches the following line and extract mmtk/jikesrvm. If this line is updated, please check ci yaml files and make sure it works.
 jikesrvm_repo = "https://github.com/mmtk/jikesrvm.git"
-jikesrvm_version = "1191b3846b6528011bce12996bbb5e15a23a043f"
+jikesrvm_version = "f2d3178c2c74e8c8daeb105d98e48feac51dd44d"
 
 [dependencies]
 libc = "0.2"
@@ -28,7 +28,7 @@ log = {version = "0.4", features = ["max_level_trace", "release_max_level_off"]
 # - change branch/rev
 # - change repo name
 # But other changes including adding/removing whitespaces in commented lines may break the CI.
-mmtk = { git = "https://github.com/mmtk/mmtk-core.git", rev = "dccce9063b57dde96d2e97670297aed4dc32e6e1" }
+mmtk = { git = "https://github.com/mmtk/mmtk-core.git", rev = "56b2521d2b99848ee0613a0a5288fe6d81b754ba" }
 # Uncomment the following to build locally - if you change the path locally, do not commit the change in a PR
 # mmtk = { path = "../repos/mmtk-core" }
 

mmtk/Cargo.toml

@@ -1,4 +1,4 @@
-use crate::scanning::EDGES_BUFFER_CAPACITY;
+use crate::scanning::SLOTS_BUFFER_CAPACITY;
 use collection::VMCollection;
 use collection::BOOT_THREAD;
 use libc::c_char;
@@ -25,7 +25,7 @@ use SINGLETON;
 /// Caller needs to make sure the ptr is a valid vector pointer.
 #[no_mangle]
 pub unsafe extern "C" fn release_buffer(ptr: *mut Address) {
-    let _vec = Vec::<Address>::from_raw_parts(ptr, 0, EDGES_BUFFER_CAPACITY);
+    let _vec = Vec::<Address>::from_raw_parts(ptr, 0, SLOTS_BUFFER_CAPACITY);
 }
 
 #[no_mangle]

mmtk/src/api.rs

@@ -43,11 +43,11 @@ pub static mut JTOC_BASE: Address = Address::ZERO;
 #[derive(Default)]
 pub struct JikesRVM;
 
-/// The type of edges in JikesRVM.
+/// The type of slots in JikesRVM.
 ///
 /// TODO: We start with Address to ease the transition.
-/// We should switch to the equivalent `mmtk::vm::edge_shape::SimpleEdge` later.
-pub type JikesRVMEdge = Address;
+/// We should switch to the equivalent `mmtk::vm::slot::SimpleSlot` later.
+pub type JikesRVMSlot = Address;
 
 impl VMBinding for JikesRVM {
     type VMObjectModel = object_model::VMObjectModel;
@@ -56,8 +56,8 @@ impl VMBinding for JikesRVM {
     type VMActivePlan = active_plan::VMActivePlan;
     type VMReferenceGlue = reference_glue::VMReferenceGlue;
 
-    type VMEdge = JikesRVMEdge;
-    type VMMemorySlice = mmtk::vm::edge_shape::UnimplementedMemorySlice<JikesRVMEdge>;
+    type VMSlot = JikesRVMSlot;
+    type VMMemorySlice = mmtk::vm::slot::UnimplementedMemorySlice<JikesRVMSlot>;
 
     #[cfg(target_arch = "x86")]
     // On Intel we align code to 16 bytes as recommended in the optimization manual.

mmtk/src/lib.rs

@@ -1,7 +1,7 @@
-use crate::scanning::EDGES_BUFFER_CAPACITY;
+use crate::scanning::SLOTS_BUFFER_CAPACITY;
 use crate::unboxed_size_constants::*;
 use crate::JikesRVM;
-use crate::JikesRVMEdge;
+use crate::JikesRVMSlot;
 use entrypoint::*;
 use java_size_constants::*;
 use mmtk::scheduler::*;
@@ -26,7 +26,7 @@ static REFS: AtomicUsize = AtomicUsize::new(0);
 
 pub fn scan_boot_image(
     _tls: OpaquePointer,
-    factory: &mut impl RootsWorkFactory<JikesRVMEdge>,
+    factory: &mut impl RootsWorkFactory<JikesRVMSlot>,
     subwork_id: usize,
     total_subwork: usize,
 ) {
@@ -48,22 +48,22 @@ pub fn scan_boot_image(
         ROOTS.store(0, Ordering::Relaxed);
         REFS.store(0, Ordering::Relaxed);
 
-        let mut edges = vec![];
+        let mut slots = vec![];
         while cursor < map_end {
             trace!("Processing chunk at {:x}", cursor);
-            process_chunk(cursor, image_start, map_start, map_end, |edge| {
-                edges.push(edge);
-                if edges.len() >= EDGES_BUFFER_CAPACITY {
-                    let new_edges =
-                        mem::replace(&mut edges, Vec::with_capacity(EDGES_BUFFER_CAPACITY));
-                    factory.create_process_edge_roots_work(new_edges);
+            process_chunk(cursor, image_start, map_start, map_end, |slot| {
+                slots.push(slot);
+                if slots.len() >= SLOTS_BUFFER_CAPACITY {
+                    let new_slots =
+                        mem::replace(&mut slots, Vec::with_capacity(SLOTS_BUFFER_CAPACITY));
+                    factory.create_process_roots_work(new_slots);
                 }
             });
             trace!("Chunk processed successfully");
             cursor += stride;
         }
-        if !edges.is_empty() {
-            factory.create_process_edge_roots_work(edges);
+        if !slots.is_empty() {
+            factory.create_process_roots_work(slots);
         }
     }
 }
@@ -73,7 +73,7 @@ fn process_chunk(
     image_start: Address,
     _map_start: Address,
     map_end: Address,
-    mut report_edge: impl FnMut(Address),
+    mut report_slot: impl FnMut(Address),
 ) {
     let mut value: usize;
     let mut offset: usize = 0;
@@ -106,7 +106,7 @@ fn process_chunk(
                 if cfg!(feature = "debug") {
                     ROOTS.fetch_add(1, Ordering::Relaxed);
                 }
-                report_edge(slot);
+                report_slot(slot);
             }
             if runlength != 0 {
                 for _ in 0..runlength {
@@ -121,7 +121,7 @@ fn process_chunk(
                             ROOTS.fetch_add(1, Ordering::Relaxed);
                         }
                         // TODO: check_reference(slot) ?
-                        report_edge(slot);
+                        report_slot(slot);
                     }
                 }
             }
@@ -141,13 +141,13 @@ fn decode_long_encoding(cursor: Address) -> usize {
     }
 }
 
-pub struct ScanBootImageRoots<F: RootsWorkFactory<JikesRVMEdge>> {
+pub struct ScanBootImageRoots<F: RootsWorkFactory<JikesRVMSlot>> {
     factory: F,
     subwork_id: usize,
     total_subwork: usize,
 }
 
-impl<F: RootsWorkFactory<JikesRVMEdge>> ScanBootImageRoots<F> {
+impl<F: RootsWorkFactory<JikesRVMSlot>> ScanBootImageRoots<F> {
     pub fn new(factory: F, subwork_id: usize, total_subwork: usize) -> Self {
         Self {
             factory,
@@ -157,7 +157,7 @@ impl<F: RootsWorkFactory<JikesRVMEdge>> ScanBootImageRoots<F> {
     }
 }
 
-impl<F: RootsWorkFactory<JikesRVMEdge>> GCWork<JikesRVM> for ScanBootImageRoots<F> {
+impl<F: RootsWorkFactory<JikesRVMSlot>> GCWork<JikesRVM> for ScanBootImageRoots<F> {
     fn do_work(&mut self, _worker: &mut GCWorker<JikesRVM>, _mmtk: &'static MMTK<JikesRVM>) {
         scan_boot_image(
             OpaquePointer::UNINITIALIZED,