Skip to content

Commit 5e38f5a

Browse files
committed
use SQLAlchemy 1.1 for tests
1 parent 3a7c84d commit 5e38f5a

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

instrumentation/opentelemetry-instrumentation-sqlalchemy/tests/test_sqlalchemy.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ def test_trace_integration(self):
4343

4444
@pytest.mark.skipif(
4545
not sqlalchemy.__version__.startswith("1.4"),
46-
reason="on run async tests for 1.4",
46+
reason="only run async tests for 1.4",
4747
)
4848
def test_async_trace_integration(self):
4949
async def run():
@@ -97,7 +97,7 @@ def test_create_engine_wrapper(self):
9797

9898
@pytest.mark.skipif(
9999
not sqlalchemy.__version__.startswith("1.4"),
100-
reason="on run async tests for 1.4",
100+
reason="only run async tests for 1.4",
101101
)
102102
def test_create_async_engine_wrapper(self):
103103
async def run():

tox.ini

+5-5
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,8 @@ envlist =
122122
py3{6,7,8,9}-test-instrumentation-grpc
123123

124124
; opentelemetry-instrumentation-sqlalchemy
125-
py3{6,7,8,9}-test-instrumentation-sqlalchemy{13,14}
126-
pypy3-test-instrumentation-sqlalchemy{13,14}
125+
py3{6,7,8,9}-test-instrumentation-sqlalchemy{11,14}
126+
pypy3-test-instrumentation-sqlalchemy{11,14}
127127

128128
; opentelemetry-instrumentation-redis
129129
py3{6,7,8,9}-test-instrumentation-redis
@@ -173,7 +173,7 @@ deps =
173173
elasticsearch6: elasticsearch>=6.0,<7.0
174174
elasticsearch7: elasticsearch-dsl>=7.0,<8.0
175175
elasticsearch7: elasticsearch>=7.0,<8.0
176-
sqlalchemy13: sqlalchemy~=1.3,<1.4
176+
sqlalchemy11: sqlalchemy>=1.1,<1.2
177177
sqlalchemy14: aiosqlite
178178
sqlalchemy14: sqlalchemy~=1.4
179179

@@ -208,7 +208,7 @@ changedir =
208208
test-instrumentation-redis: instrumentation/opentelemetry-instrumentation-redis/tests
209209
test-instrumentation-requests: instrumentation/opentelemetry-instrumentation-requests/tests
210210
test-instrumentation-sklearn: instrumentation/opentelemetry-instrumentation-sklearn/tests
211-
test-instrumentation-sqlalchemy{13,14}: instrumentation/opentelemetry-instrumentation-sqlalchemy/tests
211+
test-instrumentation-sqlalchemy{11,14}: instrumentation/opentelemetry-instrumentation-sqlalchemy/tests
212212
test-instrumentation-sqlite3: instrumentation/opentelemetry-instrumentation-sqlite3/tests
213213
test-instrumentation-starlette: instrumentation/opentelemetry-instrumentation-starlette/tests
214214
test-instrumentation-tornado: instrumentation/opentelemetry-instrumentation-tornado/tests
@@ -293,7 +293,7 @@ commands_pre =
293293

294294
sklearn: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-sklearn[test]
295295

296-
sqlalchemy{13,14}: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-sqlalchemy[test]
296+
sqlalchemy{11,14}: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-sqlalchemy[test]
297297

298298
elasticsearch{2,5,6,7}: pip install {toxinidir}/opentelemetry-python-core/opentelemetry-instrumentation {toxinidir}/instrumentation/opentelemetry-instrumentation-elasticsearch[test]
299299

0 commit comments

Comments
 (0)