Skip to content

Commit e1f9855

Browse files
committed
Fixes or removes tests that build on unfulfilled assumptions.
1 parent c740965 commit e1f9855

File tree

4 files changed

+3
-109
lines changed

4 files changed

+3
-109
lines changed

src/test/java/org/mockito/internal/creation/bytebuddy/TypeCachingMockBytecodeGeneratorTest.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ public void ensure_cache_returns_different_instance_serializableMode() throws Ex
145145
}
146146

147147
@Test
148-
public void ensure_cache_returns_different_instance_defaultAnswer() throws Exception {
148+
public void ensure_cache_returns_same_instance_defaultAnswer() throws Exception {
149149
// given
150150
ClassLoader classloader_with_life_shorter_than_cache =
151151
inMemoryClassLoader()
@@ -174,10 +174,10 @@ public void ensure_cache_returns_different_instance_defaultAnswer() throws Excep
174174
SerializableMode.NONE,
175175
false,
176176
answer));
177-
assertThat(classes.add(klass)).isTrue();
177+
assertThat(classes.add(klass)).isFalse();
178178
}
179179

180-
assertThat(classes).hasSize(answers.length + 1);
180+
assertThat(classes).hasSize(1);
181181
}
182182

183183
@Test

src/test/java/org/mockitousage/spies/MockCreationShouldNotAffectSpyTest.java

-48
This file was deleted.

src/test/java/org/mockitousage/spies/SpyCreationShouldNotAffectMockTest.java

-48
This file was deleted.

src/test/java/org/mockitousage/spies/SpyingOnRealObjectsTest.java

-10
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
import static org.junit.Assume.assumeTrue;
1010
import static org.mockito.Mockito.*;
1111

12-
import java.util.ArrayList;
1312
import java.util.Arrays;
1413
import java.util.LinkedList;
1514
import java.util.List;
@@ -193,13 +192,4 @@ public void shouldSayNiceMessageWhenSpyingOnPrivateClass() throws Exception {
193192
"Most likely it is due to mocking a private class that is not visible to Mockito");
194193
}
195194
}
196-
197-
@Test
198-
public void spysHashCodeEqualsDelegatedToActualMethods() {
199-
List<String> real = new ArrayList<>();
200-
real.add("one");
201-
List<String> spy = spy(real);
202-
assertEquals(real.hashCode(), spy.hashCode());
203-
assertTrue(spy.equals(real));
204-
}
205195
}

0 commit comments

Comments
 (0)