Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ILogger to be used for sending logs to clients #59

Open
stephentoub opened this issue Mar 22, 2025 · 3 comments
Open

Enable ILogger to be used for sending logs to clients #59

stephentoub opened this issue Mar 22, 2025 · 3 comments
Assignees

Comments

@stephentoub
Copy link
Contributor

No description provided.

@stephentoub stephentoub self-assigned this Mar 22, 2025
@Redth
Copy link
Contributor

Redth commented Mar 23, 2025

I started looking at this. I'm not sure how exactly we'd want it to work, but I was thinking of basically creating McpLoggerProvider and McpLogger which could have the IMcpServer injected so it could send a logging notification message if the logging level requested/set by the client is suitable.

I can send a draft PR with some ideas I was playing with.

@stephentoub
Copy link
Contributor Author

stephentoub commented Mar 23, 2025

@Redth , thanks. I actually have it implemented, but hit a few snags for things to be addressed first. Please hold off on this one, but once I land a few other changes first I can send you what I have if you want to build off it / finish it.

@Redth
Copy link
Contributor

Redth commented Mar 23, 2025

I made a draft PR anyway since I had the code basically done that's up there now after playing a bit today. Totally fine if you want to just close it in favour of your own implementation, but thought since I had it already, was worth sharing.

@stephentoub stephentoub removed their assignment Mar 26, 2025
@stephentoub stephentoub self-assigned this Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants