Skip to content

Commit 62ece3a

Browse files
committed
refactor: improve MCP client timeout handling and client tests
- Add separate initializationTimeout configuration parameter distinct from requestTimeout - Change ping() method to return Void instead of Object for better API clarity - Refactor tests to consistently use StepVerifier instead of mixing assertion styles - Rename ServletSse* test classes to HttpSse* for better naming consistency Signed-off-by: Christian Tzolov <[email protected]>
1 parent 29bf4df commit 62ece3a

File tree

4 files changed

+821
-817
lines changed

4 files changed

+821
-817
lines changed

Diff for: mcp-spring/mcp-spring-webflux/src/test/java/io/modelcontextprotocol/client/WebFluxSseMcpAsyncClientTests.java

-8
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44

55
package io.modelcontextprotocol.client;
66

7-
import java.time.Duration;
8-
97
import io.modelcontextprotocol.client.transport.WebFluxSseClientTransport;
108
import io.modelcontextprotocol.spec.ClientMcpTransport;
119
import org.junit.jupiter.api.Timeout;
@@ -47,10 +45,4 @@ protected void onStart() {
4745
public void onClose() {
4846
container.stop();
4947
}
50-
51-
@Override
52-
protected Duration getTimeoutDuration() {
53-
return Duration.ofMillis(1000);
54-
}
55-
5648
}

Diff for: mcp-spring/mcp-spring-webflux/src/test/java/io/modelcontextprotocol/client/WebFluxSseMcpSyncClientTests.java

-8
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44

55
package io.modelcontextprotocol.client;
66

7-
import java.time.Duration;
8-
97
import io.modelcontextprotocol.client.transport.WebFluxSseClientTransport;
108
import io.modelcontextprotocol.spec.ClientMcpTransport;
119
import org.junit.jupiter.api.Timeout;
@@ -47,10 +45,4 @@ protected void onStart() {
4745
protected void onClose() {
4846
container.stop();
4947
}
50-
51-
@Override
52-
protected Duration getTimeoutDuration() {
53-
return Duration.ofMillis(1000);
54-
}
55-
5648
}

0 commit comments

Comments
 (0)