Skip to content

Clean up the HttpClientSseClientTransport creation #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tzolov opened this issue Apr 7, 2025 · 2 comments
Closed

Clean up the HttpClientSseClientTransport creation #114

tzolov opened this issue Apr 7, 2025 · 2 comments
Labels
client enhancement New feature or request

Comments

@tzolov
Copy link
Contributor

tzolov commented Apr 7, 2025

  • Create the transport via Builder only. Reduce the constructor access to protected/private.
  • Provide HttpClient.Builder and HttpRequest.Builder customizers to modify the builders before creating the transport.
@tzolov tzolov added enhancement New feature or request client labels Apr 7, 2025
@tzolov
Copy link
Contributor Author

tzolov commented Apr 7, 2025

To address this #101 as well

@Aliaksie Aliaksie mentioned this issue Apr 7, 2025
Closed
9 tasks
@tzolov
Copy link
Contributor Author

tzolov commented Apr 9, 2025

Resolved by fab434c

@tzolov tzolov closed this as completed Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tzolov