Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to set server instructions, always null #98

Closed
codezjx opened this issue Apr 1, 2025 · 1 comment · Fixed by #99
Closed

Unable to set server instructions, always null #98

codezjx opened this issue Apr 1, 2025 · 1 comment · Fixed by #99
Assignees
@tzolov

Comments

@codezjx
Copy link
Contributor

codezjx commented Apr 1, 2025 •
edited
Loading

Bug description

Server Instructions always null and unable to change, server response as following:

19:52:30.866 [pool-1-thread-1] INFO i.m.client.McpAsyncClient - Server response with Protocol: 2024-11-05, Capabilities: ServerCapabilities[experimental=null, logging=LoggingCapabilities[], prompts=null, resources=null, tools=ToolCapabilities[listChanged=false]], Info: Implementation[name=stdio-server-example, version=1.0.0] and Instructions null

Environment
MCP Java sdk version: 0.9.0-SNAPSHOT

Expected behavior
Support set instructions when init, eg:

McpSyncServer server = McpServer.sync(transport)
    .serverInfo("stdio-server-example", "1.0.0")
    .instructions("This is a simple MCP server example that provides two tools: xxxx.")
    .tool(xxx)
    .build();

Source code
It seems that Instructions is currently fixed to null

java-sdk/mcp/src/main/java/io/modelcontextprotocol/server/McpAsyncServer.java

Lines 353 to 354 in 79ec5b5

return Mono.just(new McpSchema.InitializeResult(serverProtocolVersion, this.serverCapabilities,
this.serverInfo, null));

codezjx added a commit to codezjx/java-sdk that referenced this issue Apr 1, 2025
@codezjx
fix: add support to set instructions as mentioned in modelcontextprot…
898e8d5 
…ocol#98
@codezjx codezjx mentioned this issue Apr 1, 2025
Merged
9 tasks
@tzolov tzolov self-assigned this Apr 2, 2025
@tzolov
Copy link
Contributor

tzolov commented Apr 2, 2025

Yeh, this looks like an issue. Thanks for catching it @codezjx . Will try to review it over the weekend.

tzolov pushed a commit that referenced this issue Apr 5, 2025
@codezjx
fix: add support to set instructions as mentioned in #98 (#99)
15a55b6
@tzolov tzolov closed this as completed in #99 Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tzolov tzolov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add support to set server instructions codezjx/java-sdk
2 participants
@tzolov @codezjx