MCP Client Environment Variables in StdioServerParameters

[AshuJoshi]

Describe the bug
Passing environment variables to the MCP Server - I am trying to test the example Weather MCP Server with both the MCP Inspector and a simple Python MCP Client, and when I try to pass the Open Weather API key using the 'env' field - I cannot it to work.

To Reproduce
Steps to reproduce the behavior:

1. Use StdioServerParameters to configure connect with MCP server in Python Client
2. Specify the Open Weather Key in the parameters
3. When running the Python client - you get an error
   [Errno 2] No such file or directory: 'uv'

Here is the code snippet from the Python Client:

server_params = StdioServerParameters(
        command="uv",
        args=[
            "--directory",
            "<PATH-TO-SERVER>/weather_service",
            "run",
            "weather-service"
            ],
        # env=None
        env={
            "OPENWEATHER_API_KEY" : API_KEY
        }
    )

    # Initialize MCP client with server parameters
    async with MCPClient(server_params) as mcp_client:

If I do not pass any environment by either commenting the env field or remove it all together, then the Client is able to connect with the Server.
Are there any examples on using StdioServerParameters in Python Clients? I could not find any examples (other than env=None) in example MCP Client code.

[christopherhwood]

You need to make sure to include the necessary default env vars for it to find the uv program. When you set env to None then it uses these default env vars:

python-sdk/src/mcp/client/stdio.py

Lines 13 to 51 in aaf32b5

	# Environment variables to inherit by default
	DEFAULT_INHERITED_ENV_VARS = (
	[
	"APPDATA",
	"HOMEDRIVE",
	"HOMEPATH",
	"LOCALAPPDATA",
	"PATH",
	"PROCESSOR_ARCHITECTURE",
	"SYSTEMDRIVE",
	"SYSTEMROOT",
	"TEMP",
	"USERNAME",
	"USERPROFILE",
	]
	if sys.platform == "win32"
	else ["HOME", "LOGNAME", "PATH", "SHELL", "TERM", "USER"]
	)
	def get_default_environment() -> dict[str, str]:
	"""
	Returns a default environment object including only environment variables deemed
	safe to inherit.
	"""
	env: dict[str, str] = {}
	for key in DEFAULT_INHERITED_ENV_VARS:
	value = os.environ.get(key)
	if value is None:
	continue
	if value.startswith("()"):
	# Skip functions, which are a security risk
	continue
	env[key] = value
	return env

As a fast workaround, if you copy over the above code for the get_default_environment and use that as the base env dict, then update with your new env vars and pass that through to the mcp then you should see it working, something like this:

async def connect_to_server(self, server_config: ServerConfig):
    env = get_default_environment()
    env.update(server_config.env) if server_config.env else None

    server_params = StdioServerParameters(
        command=server_config.command,
        args=server_config.args,
        env=env
    )
    # rest of code here...

[kzmszk]

I believe it would be much better to apply the above code into the sdk.

https://github.com/modelcontextprotocol/python-sdk/blob/main/src/mcp/client/stdio.py#L100-L103

[BryceShakeAir]

I propose adding an optional flag append_default_env_vars to StdioServerParameters to control whether default environment variables should be merged with custom environment variables. This would maintain backward compatibility
Example:

class StdioServerParameters(BaseModel):
    append_default_env_vars: bool = Field(default=False, 
        description="When True, merges default environment variables with custom env")

[zhjch05]

Oh I just saw this and I found similar errors and I proposed some code in #185 too

we can have a flag like @BryceShakeAir mentioned and then merge the env vars like this

process = await anyio.open_process(
      [server.command, *server.args],
      env={
          **get_default_environment(),
          **(server.env or {})
      },
      stderr=sys.stderr,
)

[sbshah97]

Is this issue still open for contribution? Would love to send a documentation patch if that helps?

[ggozad]

I stumbled upon this because of ggozad/oterm#188

When the server configuration defines an environment, connecting to the server runs without the default environment, which includes the PATH var. Often uvx, npx, docker will not be found which means that any server will fail to load. This is the case for MacOS & brew for example.

In addition, passing the entire environment (as is the case when the configuration does not define an environment) does involve the security risk of exposing sensitive env variables.

Perhaps setting the default env to include PATH and then updating it with the server config's env, would resolve the issue?

[Kludex]

This is going to be fixed in 1.5.0. 🙏