Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 49944a6

Browse files
committedNov 26, 2024··
Use windowsHide because detached seems to break stdio redirection on npx
1 parent 593bee6 commit 49944a6

File tree

1 file changed

+1
-10
lines changed

1 file changed

+1
-10
lines changed
 

Diff for: ‎src/client/stdio.ts

+1-10
Original file line numberDiff line numberDiff line change
@@ -113,16 +113,7 @@ export class StdioClientTransport implements Transport {
113113
stdio: ["pipe", "pipe", this._serverParams.stderr ?? "inherit"],
114114
shell: false,
115115
signal: this._abortController.signal,
116-
117-
// NB: The behavior of detached varies based on platform, and also
118-
// is different based on whether the process is a Win32 Subsystem
119-
// process or a Console Subsystem process. Strangely, the behavior
120-
// of detached is almost 1:1 the opposite in Electron+Windows vs
121-
// what is documented on the node.js website, and also is different
122-
// based on whether you launch Electron in a development environment
123-
// (i.e. via `electron-forge start`) vs a production environment
124-
// (i.e. YourApp.exe).
125-
detached: process.platform === "win32" && isElectron(),
116+
windowsHide: process.platform === "win32" && isElectron(),
126117
}
127118
);
128119

0 commit comments

Comments
 (0)
Please sign in to comment.