Skip to content

Commit a5d5816

Browse files
akirchhoff-modularmodularbot
authored andcommitted
[Pipelines] Compile multi-model pipelines' models in parallel
I observe that pipelines with multiple models (currently mostly vision models) spend a lot of their compilation time pinned to a single core. This is not an efficient use of time. We have two pieces of work, so at least have each one pinned to one core. This slows down each compile from about 70 seconds to 90 seconds, but because those 90 seconds are overlapped, this still saves about 50 seconds overall. MODULAR_ORIG_COMMIT_REV_ID: 9b7b1e12e297132f15c560e9510af673b322f18c
1 parent 1912ff7 commit a5d5816

File tree

836 files changed

+43185
-2435
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

836 files changed

+43185
-2435
lines changed

.clang-format

+2
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
BasedOnStyle: LLVM
2+
AlwaysBreakTemplateDeclarations: Yes

.clang-tidy

+57
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,57 @@
1+
InheritParentConfig: true
2+
Checks: >
3+
bugprone-argument-comment,
4+
bugprone-assert-side-effect,
5+
bugprone-branch-clone,
6+
bugprone-copy-constructor-init,
7+
bugprone-dangling-handle,
8+
bugprone-dynamic-static-initializers,
9+
bugprone-macro-parentheses,
10+
bugprone-macro-repeated-side-effects,
11+
bugprone-misplaced-widening-cast,
12+
bugprone-move-forwarding-reference,
13+
bugprone-multiple-statement-macro,
14+
bugprone-suspicious-semicolon,
15+
bugprone-swapped-arguments,
16+
bugprone-terminating-continue,
17+
bugprone-unused-raii,
18+
bugprone-unused-return-value,
19+
misc-redundant-expression,
20+
misc-static-assert,
21+
misc-unused-using-decls,
22+
modernize-use-bool-literals,
23+
modernize-loop-convert,
24+
modernize-make-unique,
25+
modernize-raw-string-literal,
26+
modernize-use-equals-default,
27+
modernize-use-default-member-init,
28+
modernize-use-emplace,
29+
modernize-use-nullptr,
30+
modernize-use-override,
31+
modernize-use-using,
32+
performance-for-range-copy,
33+
performance-implicit-conversion-in-loop,
34+
performance-inefficient-algorithm,
35+
performance-inefficient-vector-operation,
36+
performance-move-const-arg,
37+
performance-no-automatic-move,
38+
performance-trivially-destructible,
39+
performance-unnecessary-copy-initialization,
40+
performance-unnecessary-value-param,
41+
readability-avoid-const-params-in-decls,
42+
readability-const-return-type,
43+
readability-container-size-empty,
44+
readability-inconsistent-declaration-parameter-name,
45+
readability-misleading-indentation,
46+
readability-redundant-control-flow,
47+
readability-redundant-smartptr-get,
48+
readability-simplify-subscript-expr,
49+
readability-use-anyofallof
50+
51+
CheckOptions:
52+
- key: readability-identifier-naming.MemberCase
53+
value: camelBack
54+
- key: readability-identifier-naming.ParameterCase
55+
value: camelBack
56+
- key: readability-identifier-naming.VariableCase
57+
value: camelBack

.gitattributes

+4
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
# Add an override so that .🔥 files are highlighted as Mojo files within github
2+
# since the linguist system does not work with the .🔥 extention.
3+
# See https://github.com/github/linguist/blob/master/docs/overrides.md
4+
*.🔥 linguist-language=Mojo

.github/ISSUE_TEMPLATE/CODEOWNERS

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
# Codeowners for MAX repo.
2+
# Every line is a file pattern that is followed by one or more code owners.
3+
# Order is important; the last matching pattern takes the most precedence.
4+
5+
* @modularml/max-code-reviewers

.github/ISSUE_TEMPLATE/doc_issue.yaml

+3-2
Original file line numberDiff line numberDiff line change
@@ -12,19 +12,20 @@
1212
##===----------------------------------------------------------------------===##
1313

1414
name: Documentation issue
15-
description: Report a problem with the Mojo docs
15+
description: Report a problem with the MAX docs
1616
title: "[Docs]"
1717
labels:
1818
- documentation
1919
body:
2020
- type: markdown
2121
attributes:
2222
value: |
23-
Thank you for helping us improve the Mojo docs!
23+
Thank you for helping us improve the MAX docs!
2424
2525
Please add a title above and fill in the following fields so we can understand the problem.
2626
2727
- type: input
28+
id: url
2829
attributes:
2930
label: Where is the problem?
3031
description: Provide a link to the problematic page (with a heading anchor).
+55
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
1+
##===----------------------------------------------------------------------===##
2+
# Copyright (c) 2025, Modular Inc. All rights reserved.
3+
#
4+
# Licensed under the Apache License v2.0 with LLVM Exceptions:
5+
# https://llvm.org/LICENSE.txt
6+
#
7+
# Unless required by applicable law or agreed to in writing, software
8+
# distributed under the License is distributed on an "AS IS" BASIS,
9+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
10+
# See the License for the specific language governing permissions and
11+
# limitations under the License.
12+
##===----------------------------------------------------------------------===##
13+
14+
name: MAX bug report
15+
description: Create a bug report to help us improve MAX
16+
title: "[BUG]: "
17+
labels:
18+
- bug
19+
body:
20+
- type: markdown
21+
attributes:
22+
value: |
23+
Thanks for taking the time to fill out a bug report!
24+
25+
Please provide a descriptive title above and fill in the following fields.
26+
27+
- type: textarea
28+
id: Description
29+
attributes:
30+
label: Bug description
31+
description: Describe the bug you encountered and what you expected to happen.
32+
validations:
33+
required: true
34+
35+
- type: textarea
36+
id: Steps
37+
attributes:
38+
label: Steps to reproduce
39+
description: Provide the specific steps to reproduce the issue.
40+
value: |
41+
- Include relevant code snippet or link to code that did not work as expected.
42+
- If applicable, add screenshots to help explain the problem.
43+
- Include anything else that might help us debug the issue.
44+
validations:
45+
required: true
46+
47+
- type: textarea
48+
id: Context
49+
attributes:
50+
label: System information
51+
description: What version of MAX are you using?
52+
value: |
53+
- Provide the system information by running `magic info`.
54+
- Provide version information for MAX (includes Mojo) by pasting the output of `magic list max`.
55+
render: shell
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
1+
##===----------------------------------------------------------------------===##
2+
# Copyright (c) 2025, Modular Inc. All rights reserved.
3+
#
4+
# Licensed under the Apache License v2.0 with LLVM Exceptions:
5+
# https://llvm.org/LICENSE.txt
6+
#
7+
# Unless required by applicable law or agreed to in writing, software
8+
# distributed under the License is distributed on an "AS IS" BASIS,
9+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
10+
# See the License for the specific language governing permissions and
11+
# limitations under the License.
12+
##===----------------------------------------------------------------------===##
13+
14+
name: MAX Builds model bug report
15+
description: Report a bug with a model
16+
title: "[BUG]: "
17+
labels:
18+
- bug
19+
body:
20+
- type: markdown
21+
attributes:
22+
value: |
23+
Thanks for taking the time to fill out a bug report!
24+
25+
Please provide a descriptive title above and fill in the following fields.
26+
27+
- type: input
28+
id: model-variant
29+
attributes:
30+
label: On which model did the bug occur?
31+
description: Provide the model (and variant).
32+
validations:
33+
required: true
34+
35+
- type: textarea
36+
id: Description
37+
attributes:
38+
label: Bug description
39+
description: Describe the bug you encountered and what you expected to happen.
40+
validations:
41+
required: true
42+
43+
- type: textarea
44+
id: Steps
45+
attributes:
46+
label: Steps to reproduce
47+
description: Provide the specific steps to reproduce the issue.
48+
value: |
49+
- Include relevant code snippet or link to code that did not work as expected.
50+
- If applicable, add screenshots to help explain the problem.
51+
- Include anything else that might help us debug the issue.
52+
validations:
53+
required: true
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
##===----------------------------------------------------------------------===##
2+
# Copyright (c) 2025, Modular Inc. All rights reserved.
3+
#
4+
# Licensed under the Apache License v2.0 with LLVM Exceptions:
5+
# https://llvm.org/LICENSE.txt
6+
#
7+
# Unless required by applicable law or agreed to in writing, software
8+
# distributed under the License is distributed on an "AS IS" BASIS,
9+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
10+
# See the License for the specific language governing permissions and
11+
# limitations under the License.
12+
##===----------------------------------------------------------------------===##
13+
14+
name: MAX feature request
15+
description: Suggest an enhancement for MAX
16+
title: "[Feature Request]"
17+
labels:
18+
- enhancement
19+
body:
20+
- type: markdown
21+
attributes:
22+
value: |
23+
Thanks for taking the time to suggest a MAX enhancement!
24+
25+
Please enter a concise title above and fill out the following fields.
26+
27+
- type: textarea
28+
id: Request
29+
attributes:
30+
label: What is your request?
31+
description: Describe how you'd like us to improve MAX.
32+
validations:
33+
required: true
34+
35+
- type: textarea
36+
id: Motivation
37+
attributes:
38+
label: What is your motivation for this change?
39+
description: Describe the problem that your feature seeks to address (what is the value to the product/user?).
40+
validations:
41+
required: true
42+
43+
- type: textarea
44+
id: Description
45+
attributes:
46+
label: Any other details?
47+
description: Perhaps some minimum functional attributes the implementation should include, or other context about your feature.
48+
validations:
49+
required: false

0 commit comments

Comments
 (0)