Skip to content

Commit feb8ab6

Browse files
yan12125mokibit
authored andcommitted
www: fix links in the about page
Somehow <Link> forces relative links and breaks external URLs (ex: https://buildbot.buildbot.net/#/about/http://buildbot.net). It might be fixed with react-router 6.7.1 [1], while I prefer to just use basic `<a>`. While I'm at it, I also updated the link to use HTTPS. [1] remix-run/react-router#9900
1 parent 645d286 commit feb8ab6

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fix links to external URLs in the about pages.

www/base/src/views/AboutView/AboutView.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,8 @@ export const AboutView = observer(() => {
8888
<Card.Body>
8989
<h2>
9090
<img src="icon.svg" alt="" width="64px" className="nut-spin"/>&nbsp;About this&nbsp;
91-
<Link to="http://buildbot.net">buildbot</Link>&nbsp;running for&nbsp;
92-
<Link to={config.titleURL}>{config.title}</Link>
91+
<a href="https://buildbot.net">buildbot</a>&nbsp;running for&nbsp;
92+
<a href={config.titleURL}>{config.title}</a>
9393
</h2>
9494
<div className="col-sm-12">
9595
<ul>

www/react-base/src/views/AboutView/AboutView.tsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,9 @@ export const AboutView = observer(() => {
8787
<Card bg="light">
8888
<Card.Body>
8989
<h2>
90-
<img src="img/icon.svg" alt="" width="64px" className="nut-spin"/>&nbsp;About this&nbsp;
91-
<Link to="http://buildbot.net">buildbot</Link>&nbsp;running for&nbsp;
92-
<Link to={config.titleURL}>{config.title}</Link>
90+
<img src="icon.svg" alt="" width="64px" className="nut-spin"/>&nbsp;About this&nbsp;
91+
<a href="https://buildbot.net">buildbot</a>&nbsp;running for&nbsp;
92+
<a href={config.titleURL}>{config.title}</a>
9393
</h2>
9494
<div className="col-sm-12">
9595
<ul>

0 commit comments

Comments
 (0)