Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mongodb-js/mongodb-client-encryption
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.2.0
Choose a base ref
...
head repository: mongodb-js/mongodb-client-encryption
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.2.1
Choose a head ref
  • 2 commits
  • 4 files changed
  • 2 contributors

Commits on Feb 5, 2021

  1. fix: always authorize TLS endpoints, use servername for SNI (#159)

    TLS endpoints should always be authorized. 
    In order to properly communicate with GCP's KMS servers
    we need to provide a `servername`, so the endpoint can serve the
    correct TLS certificate.
    mbroadst authored Feb 5, 2021
    Copy the full SHA
    c571e46 View commit details
  2. chore(release): 1.2.1

    nbbeeken committed Feb 5, 2021
    Copy the full SHA
    2163a43 View commit details
Showing with 5 additions and 3 deletions.
  1. +2 −0 CHANGELOG.md
  2. +1 −1 lib/stateMachine.js
  3. +1 −1 package-lock.json
  4. +1 −1 package.json
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -2,6 +2,8 @@

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

### [1.2.1](https://github.com/mongodb/libmongocrypt/compare/node-v1.2.0...node-v1.2.1) (2021-02-05)

## [1.2.0](https://github.com/mongodb/libmongocrypt/compare/node-v1.1.0...node-v1.2.0) (2021-02-02)

### [1.1.1-beta.0](https://github.com/mongodb/libmongocrypt/compare/node-v1.1.0...node-v1.1.1-beta.0) (2020-12-04)
2 changes: 1 addition & 1 deletion lib/stateMachine.js
Original file line number Diff line number Diff line change
@@ -217,7 +217,7 @@ module.exports = function(modules) {
kmsRequest(request) {
const parsedUrl = request.endpoint.split(':');
const port = parsedUrl[1] != null ? Number.parseInt(parsedUrl[1], 10) : HTTPS_PORT;
const options = { host: parsedUrl[0], port, rejectUnauthorized: false };
const options = { host: parsedUrl[0], servername: parsedUrl[0], port };
const message = request.message;

return new Promise((resolve, reject) => {
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "mongodb-client-encryption",
"version": "1.2.0",
"version": "1.2.1",
"description": "Official client encryption module for the MongoDB Node.js driver",
"main": "index.js",
"types": "index.d.ts",