Skip to content

feat(NODE-6695): enable KMS retry protocol #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Conversation

durran
Copy link
Member

@durran durran commented Jan 30, 2025

Description

Exposes methods required to retry KMS requests and enables them in libmongocrypt.

What is changing?

  • Set the flag to retry KMS requests.
  • Adds uSleep property and fail method.
  • Bumps libmongocrypt to 1.12.
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-6695

Release Highlight

KMS requests are now retryable

Retrying KMS requests is now enabled and the new method uSleep and fail property are now exposed to handle the feature in the driver.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran marked this pull request as ready for review January 30, 2025 17:46
@baileympearson baileympearson merged commit d4b7ef7 into main Jan 30, 2025
30 checks passed
@baileympearson baileympearson deleted the NODE-6695 branch January 30, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants