Skip to content

Commit bbe0e38

Browse files
committed
chore: update node driver to 4.0.0-beta.5 MONGOSH-795
1 parent 591dd71 commit bbe0e38

15 files changed

+58
-56
lines changed

package-lock.json

+5-5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@
117117
"karma-typescript": "^4.1.1",
118118
"lerna": "^3.10.7",
119119
"mocha": "^7.1.2",
120-
"mongodb": "4.0.0-beta.4",
120+
"mongodb": "4.0.0-beta.5",
121121
"mongodb-download-url": "^1.0.1",
122122
"mongodb-js-precommit": "^2.0.0",
123123
"nock": "^13.0.11",

packages/service-provider-core/package-lock.json

+5-5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/service-provider-core/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
"@mongosh/errors": "0.0.0-dev.0",
3131
"@mongosh/i18n": "0.0.0-dev.0",
3232
"bson": "^4.4.0",
33-
"mongodb": "4.0.0-beta.4",
33+
"mongodb": "4.0.0-beta.5",
3434
"mongodb-build-info": "^1.1.1",
3535
"whatwg-url": "^8.4.0"
3636
},

packages/service-provider-core/src/all-transport-types.ts

+5-6
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,11 @@ export type {
5151
OrderedBulkOperation,
5252
ReadConcern,
5353
ReadConcernLike,
54-
ReadConcernLevelId,
54+
ReadConcernLevel,
5555
ReadPreference,
5656
ReadPreferenceLike,
5757
ReadPreferenceFromOptions,
58-
ReadPreferenceModeId,
58+
ReadPreferenceMode,
5959
RenameOptions,
6060
ReplaceOptions,
6161
ResumeToken,
@@ -70,12 +70,11 @@ export type {
7070
ObjectId as ObjectIdType,
7171
Timestamp as TimestampType,
7272
Binary as BinaryType,
73-
Topology,
7473
TopologyDescription,
75-
TopologyTypeId,
76-
ServerTypeId,
74+
TopologyType,
75+
ServerType,
7776
AutoEncryptionOptions,
7877
ServerApi,
79-
ServerApiVersionId,
78+
ServerApiVersion,
8079
MongoClient // mostly for testing
8180
} from 'mongodb';

packages/service-provider-server/package-lock.json

+5-5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/service-provider-server/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
"@types/sinon": "^7.5.1",
4444
"@types/sinon-chai": "^3.2.3",
4545
"aws4": "^1.11.0",
46-
"mongodb": "4.0.0-beta.4",
46+
"mongodb": "4.0.0-beta.5",
4747
"saslprep": "mongodb-js/saslprep#v1.0.4"
4848
},
4949
"devDependencies": {

packages/service-provider-server/src/cli-service-provider.ts

+6-7
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import {
22
Auth,
3-
AuthMechanismId,
3+
AuthMechanism,
44
MongoClient,
55
ReadPreference,
66
Binary,
@@ -16,7 +16,6 @@ import {
1616
Decimal128,
1717
BSONSymbol,
1818
ClientMetadata,
19-
Topology,
2019
ReadPreferenceFromOptions,
2120
ReadPreferenceLike,
2221
OperationOptions,
@@ -110,7 +109,7 @@ type DropDatabaseResult = {
110109

111110
type ConnectionInfo = {
112111
buildInfo: any;
113-
topology: Topology;
112+
topology: any;
114113
extraInfo: ExtraConnectionInfo;
115114
};
116115
type ExtraConnectionInfo = ReturnType<typeof getConnectInfo>;
@@ -315,7 +314,7 @@ class CliServiceProvider extends ServiceProviderCore implements ServiceProvider
315314
}
316315
}
317316
}
318-
const topology = this.getTopology() as Topology;
317+
const topology = this.getTopology();
319318
const { version } = require('../package.json');
320319
const [cmdLineOpts = null, atlasVersion = null] = await Promise.all([
321320
this.runCommandWithCheck('admin', { getCmdLineOpts: 1 }, this.baseCmdOptions).catch(() => {}),
@@ -972,8 +971,8 @@ class CliServiceProvider extends ServiceProviderCore implements ServiceProvider
972971
/**
973972
* Get currently known topology information.
974973
*/
975-
getTopology(): Topology | undefined {
976-
return this.mongoClient.topology;
974+
getTopology(): any | undefined {
975+
return (this.mongoClient as any).topology;
977976
}
978977

979978
/**
@@ -1120,7 +1119,7 @@ class CliServiceProvider extends ServiceProviderCore implements ServiceProvider
11201119
const auth: Auth = { username: authDoc.user, password: authDoc.pwd };
11211120
await this.resetConnectionOptions({
11221121
auth,
1123-
...(authDoc.mechanism ? { authMechanism: authDoc.mechanism as AuthMechanismId } : {}),
1122+
...(authDoc.mechanism ? { authMechanism: authDoc.mechanism as AuthMechanism } : {}),
11241123
...(authDoc.authDb ? { authSource: authDoc.authDb } : {})
11251124
});
11261125
return { ok: 1 };

packages/service-provider-server/src/mongodb-patches.ts

+6-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
import { MongoshInternalError } from '@mongosh/errors';
2-
import { Callback, CloseOptions, Connection, ConnectionPool } from 'mongodb';
2+
import { Callback, CloseOptions } from 'mongodb';
3+
4+
// We "rename" any here for more clarity below
5+
type ConnectionPool = any;
6+
type Connection = any;
37

48
let alreadyPatched = false;
59

@@ -26,7 +30,7 @@ function patchConnectionPoolTracking(): void {
2630
const newCheckOut: typeof originalCheckOut = function(this: ConnectionPool, cb: Callback<Connection>): void {
2731
// eslint-disable-next-line @typescript-eslint/no-this-alias
2832
const pool = this;
29-
originalCheckOut.call(this, function(this: any, error, connection) {
33+
originalCheckOut.call(this, function(this: any, error: any, connection: Connection) {
3034
if (connection) {
3135
let connections = poolToConnections.get(pool);
3236
if (!connections) {

packages/shell-api/src/cursor.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import type {
1616
Document,
1717
CollationOptions,
1818
ReadPreferenceLike,
19-
ReadConcernLevelId,
19+
ReadConcernLevel,
2020
TagSet,
2121
HedgeOptions
2222
} from '@mongosh/service-provider-core';
@@ -225,7 +225,7 @@ export default class Cursor extends AbstractCursor {
225225
}
226226

227227
@returnType('Cursor')
228-
readConcern(level: ReadConcernLevelId): Cursor {
228+
readConcern(level: ReadConcernLevel): Cursor {
229229
this._cursor = this._cursor.withReadConcern({ level });
230230
return this;
231231
}

packages/shell-api/src/mongo.ts

+6-6
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,17 @@ import {
2424
Document,
2525
generateUri,
2626
ListDatabasesOptions,
27-
ReadConcernLevelId,
27+
ReadConcernLevel,
2828
ReadPreference,
2929
ReadPreferenceLike,
30-
ReadPreferenceModeId,
30+
ReadPreferenceMode,
3131
ReplPlatform,
3232
ServiceProvider,
3333
TransactionOptions,
3434
MongoClientOptions,
3535
AutoEncryptionOptions as SPAutoEncryption,
3636
ServerApi,
37-
ServerApiVersionId,
37+
ServerApiVersion,
3838
WriteConcern
3939
} from '@mongosh/service-provider-core';
4040
import type Collection from './collection';
@@ -74,7 +74,7 @@ export default class Mongo extends ShellApiClass {
7474
internalState: ShellInternalState,
7575
uri?: string,
7676
fleOptions?: ClientSideFieldLevelEncryptionOptions,
77-
otherOptions?: { api?: ServerApi | ServerApiVersionId },
77+
otherOptions?: { api?: ServerApi | ServerApiVersion },
7878
sp?: ServiceProvider
7979
) {
8080
super();
@@ -325,7 +325,7 @@ export default class Mongo extends ShellApiClass {
325325
return await this._serviceProvider.suspend();
326326
}
327327

328-
getReadPrefMode(): ReadPreferenceModeId {
328+
getReadPrefMode(): ReadPreferenceMode {
329329
return this._serviceProvider.getReadPreference().mode;
330330
}
331331

@@ -373,7 +373,7 @@ export default class Mongo extends ShellApiClass {
373373
}
374374

375375
@returnsPromise
376-
async setReadConcern(level: ReadConcernLevelId): Promise<void> {
376+
async setReadConcern(level: ReadConcernLevel): Promise<void> {
377377
await this._serviceProvider.resetConnectionOptions({ readConcern: { level: level } });
378378
}
379379

packages/shell-api/src/session.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -83,11 +83,11 @@ export default class Session extends ShellApiWithMongoClass {
8383
}
8484

8585
getClusterTime(): ClusterTime | undefined {
86-
return this._session.clusterTime;
86+
return (this._session as any).clusterTime;
8787
}
8888

8989
getOperationTime(): TimestampType | undefined {
90-
return this._session.operationTime;
90+
return (this._session as any).operationTime;
9191
}
9292

9393
getOptions(): ClientSessionOptions {

packages/shell-api/src/shell-api.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import Database from './database';
1616
import { CommandResult, CursorIterationResult } from './result';
1717
import type ShellInternalState from './shell-internal-state';
1818
import { assertArgsDefinedType, assertCLI } from './helpers';
19-
import { DEFAULT_DB, ReplPlatform, ServerApi, ServerApiVersionId } from '@mongosh/service-provider-core';
19+
import { DEFAULT_DB, ReplPlatform, ServerApi, ServerApiVersion } from '@mongosh/service-provider-core';
2020
import { CommonErrors, MongoshUnimplementedError, MongoshInternalError } from '@mongosh/errors';
2121
import { DBQuery } from './dbquery';
2222
import { promisify } from 'util';
@@ -162,7 +162,7 @@ export default class ShellApi extends ShellApiClass {
162162
public async Mongo(
163163
uri?: string,
164164
fleOptions?: ClientSideFieldLevelEncryptionOptions,
165-
otherOptions?: { api?: ServerApi | ServerApiVersionId }): Promise<Mongo> {
165+
otherOptions?: { api?: ServerApi | ServerApiVersion }): Promise<Mongo> {
166166
assertCLI(this._internalState.initialServiceProvider.platform, 'new Mongo connections');
167167
const mongo = new Mongo(this._internalState, uri, fleOptions, otherOptions);
168168
await mongo.connect();

packages/shell-api/src/shell-internal-state.spec.ts

+9-9
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { bson, ServiceProvider, Topology } from '@mongosh/service-provider-core';
1+
import { bson, ServiceProvider } from '@mongosh/service-provider-core';
22
import { expect } from 'chai';
33
import { EventEmitter } from 'events';
44
import { StubbedInstance, stubInterface } from 'ts-sinon';
@@ -59,7 +59,7 @@ describe('ShellInternalState', () => {
5959
});
6060

6161
describe('default prompt', () => {
62-
const setupServiceProviderWithTopology = (topology: Topology) => {
62+
const setupServiceProviderWithTopology = (topology: any) => {
6363
serviceProvider.getConnectionInfo.resolves({ extraInfo: { uri: 'mongodb://localhost/' } });
6464
serviceProvider.getTopology.returns(topology);
6565
};
@@ -152,7 +152,7 @@ describe('ShellInternalState', () => {
152152
setName: null, // This was observed behavior - the set was not updated even the single server had the set
153153
servers: servers
154154
}
155-
} as Topology;
155+
};
156156
setupServiceProviderWithTopology(topology);
157157

158158
const prompt = await internalState.getDefaultPrompt();
@@ -182,7 +182,7 @@ describe('ShellInternalState', () => {
182182
setName: null,
183183
servers: servers
184184
}
185-
} as Topology;
185+
};
186186
setupServiceProviderWithTopology(topology);
187187

188188
const prompt = await internalState.getDefaultPrompt();
@@ -199,7 +199,7 @@ describe('ShellInternalState', () => {
199199
type: 'ReplicaSetNoPrimary',
200200
setName: 'leSet'
201201
}
202-
} as Topology;
202+
};
203203
setupServiceProviderWithTopology(topology);
204204

205205
const prompt = await internalState.getDefaultPrompt();
@@ -213,7 +213,7 @@ describe('ShellInternalState', () => {
213213
type: 'ReplicaSetWithPrimary',
214214
setName: 'leSet'
215215
}
216-
} as Topology;
216+
};
217217
setupServiceProviderWithTopology(topology);
218218

219219
const prompt = await internalState.getDefaultPrompt();
@@ -228,7 +228,7 @@ describe('ShellInternalState', () => {
228228
// TODO: replace with TopologyType.Sharded - NODE-2973
229229
type: 'Sharded'
230230
}
231-
} as Topology;
231+
};
232232
setupServiceProviderWithTopology(topology);
233233

234234
const prompt = await internalState.getDefaultPrompt();
@@ -241,7 +241,7 @@ describe('ShellInternalState', () => {
241241
type: 'Sharded',
242242
setName: 'leSet'
243243
}
244-
} as Topology;
244+
};
245245
setupServiceProviderWithTopology(topology);
246246

247247
const prompt = await internalState.getDefaultPrompt();
@@ -287,7 +287,7 @@ describe('ShellInternalState', () => {
287287
setName: 'unknown',
288288
servers: servers
289289
}
290-
} as Topology;
290+
};
291291
setupServiceProviderWithTopology(topology);
292292

293293
const prompt = await internalState.getDefaultPrompt();

packages/shell-api/src/shell-internal-state.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
ReplPlatform,
77
ServiceProvider,
88
TopologyDescription,
9-
TopologyTypeId
9+
TopologyType
1010
} from '@mongosh/service-provider-core';
1111
import type { ApiEvent, ConfigProvider, MongoshBus, ShellUserConfig } from '@mongosh/types';
1212
import { EventEmitter } from 'events';
@@ -258,7 +258,7 @@ export default class ShellInternalState {
258258
topology: () => {
259259
let topology: Topologies;
260260
const topologyDescription = this.currentServiceProvider.getTopology()?.description as TopologyDescription;
261-
const topologyType: TopologyTypeId | undefined = topologyDescription?.type;
261+
const topologyType: TopologyType | undefined = topologyDescription?.type;
262262
switch (topologyType) {
263263
case 'ReplicaSetNoPrimary':
264264
case 'ReplicaSetWithPrimary':

0 commit comments

Comments
 (0)