chore: adds tests for oidc in vscode - VSCODE-414 (#652)

* chore: added integration tests for oidc in vscode

* chore: removed mac specific changes

* chore: fix github ci

* chore: action fixup

* chore: minor cleanup

* chore: remove the timeout and instead wait for promise resolve

* chore: review fixup

* chore: changed expectations to use chai

* chore: remove reliance on timeouts entirely

Author: himanshusinghs

.github/workflows/actions/test-and-build/action.yaml

@@ -69,7 +69,15 @@ runs:
       if: ${{ runner.os != 'Windows' }}
       shell: bash
 
+    - name: Set BROWSER_AUTH_COMMAND
+      run: |
+        BROWSER_AUTH_COMMAND=$(echo "$(which node) $(pwd)/src/test/fixture/curl.js")
+        echo "BROWSER_AUTH_COMMAND=$BROWSER_AUTH_COMMAND" >> $GITHUB_ENV
+      shell: bash
+
     - name: Run Tests
+      env:
+        BROWSER_AUTH_COMMAND: ${{ env.BROWSER_AUTH_COMMAND }}
       run: |
         npm run test
       shell: bash

package-lock.json

@@ -1029,6 +1029,11 @@
           "type": "boolean",
           "default": false,
           "description": "The default behavior is to generate a single ObjectId and insert it on all cursors. Set to true to generate a unique ObjectId per cursor instead."
+        },
+        "mdb.browserCommandForOIDCAuth": {
+          "type": "string",
+          "default": "",
+          "description": "Specify a shell command that is run to start the browser for authenticating with the OIDC identity provider for the server connection. Leave this empty for default browser."
         }
       }
     }
@@ -1071,6 +1076,7 @@
   },
   "devDependencies": {
     "@babel/preset-typescript": "^7.22.5",
+    "@mongodb-js/oidc-mock-provider": "^0.6.9",
     "@mongodb-js/oidc-plugin": "^0.3.0",
     "@mongodb-js/prettier-config-compass": "^1.0.0",
     "@mongodb-js/sbom-tools": "^0.5.4",
@@ -1122,6 +1128,7 @@
     "mocha-multi": "^1.1.7",
     "mongodb-client-encryption": "^6.0.0",
     "mongodb-runner": "^5.4.5",
+    "node-fetch": "^2.7.0",
     "node-loader": "^0.6.0",
     "npm-run-all": "^4.1.5",
     "ora": "^5.4.1",

package.json

@@ -313,22 +313,27 @@ export default class ConnectionController {
           browserCommandForOIDCAuth: undefined, // We overwrite this below.
         },
       });
+      const browserAuthCommand = vscode.workspace
+        .getConfiguration('mdb')
+        .get('browserCommandForOIDCAuth');
       dataService = await connectionAttempt.connect({
         ...connectionOptions,
         oidc: {
           ...cloneDeep(connectionOptions.oidc),
-          openBrowser: async ({ signal, url }) => {
-            try {
-              await openLink(url);
-            } catch (err) {
-              if (signal.aborted) return;
-              // If opening the link fails we default to regular link opening.
-              await vscode.commands.executeCommand(
-                'vscode.open',
-                vscode.Uri.parse(url)
-              );
-            }
-          },
+          openBrowser: browserAuthCommand
+            ? { command: browserAuthCommand }
+            : async ({ signal, url }) => {
+                try {
+                  await openLink(url);
+                } catch (err) {
+                  if (signal.aborted) return;
+                  // If opening the link fails we default to regular link opening.
+                  await vscode.commands.executeCommand(
+                    'vscode.open',
+                    vscode.Uri.parse(url)
+                  );
+                }
+              },
         },
       });
 
@@ -402,6 +407,7 @@ export default class ConnectionController {
       );
 
     if (removeConfirmationResponse !== 'Confirm') {
+      await this.disconnect();
       throw new Error('Reauthentication declined by user');
     }
   }

src/connectionController.ts

@@ -0,0 +1,13 @@
+#!/usr/bin/env node
+/* eslint-disable */
+'use strict';
+const fetch = require('node-fetch');
+
+// fetch() an URL and ignore the response body
+(async function () {
+  (await fetch(process.argv[2])).body?.resume();
+})().catch((err) => {
+  process.nextTick(() => {
+    throw err;
+  });
+});