test(NODE-5594): add tests to check rounding behaviour

Author: W-A-James

test/bench/src/suites/objectid_serialization.ts

@@ -0,0 +1,20 @@
+import { Suite } from '../suite';
+import * as BSON from '../../../../';
+
+export function getObjectIdSerializationSuite(): Suite {
+  const objectIdArray = Array.from({ length: 1000 }, () => ({ _id: new BSON.ObjectId() }));
+
+  const suite = new Suite('ObjectId serialization');
+  return suite.task({
+    name: `objectIdSerialization`,
+    data: objectIdArray,
+    fn: objectIdArray => {
+      for (const oid of objectIdArray) BSON.serialize(oid);
+    },
+    iterations: 100,
+    resultUnit: 'megabytes_per_second',
+    transform: (runtimeMS: number) => {
+      return BSON.serialize(objectIdArray).byteLength / 1024 ** 2 / (runtimeMS / 1000);
+    }
+  });
+}

test/node/decimal128.test.ts

@@ -468,7 +468,7 @@ describe('Decimal128', function () {
 
   it('fromString from string round', function (done) {
     // Create decimal from string value 10E-6177
-    let result = Decimal128.fromString('10E-6177');
+    const result = Decimal128.fromString('10E-6177');
     const bytes = Buffer.from(
       [
         0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
@@ -478,9 +478,6 @@ describe('Decimal128', function () {
 
     expect(bytes).to.deep.equal(result.bytes);
 
-    result = Decimal128.fromString('37.499999999999999196428571428571375');
-    expect(result.toString()).to.deep.equal('37.49999999999999919642857142857138');
-
     // // Create decimal from string value 15E-6177
     // result = Decimal128.fromString('15E-6177');
     // bytes = Buffer.from(
@@ -1306,6 +1303,39 @@ describe('Decimal128', function () {
           });
         }
       });
+
+      context('when the input has more than 34 significant digits', function () {
+        it('does not throw an error', function () {
+          expect(() =>
+            Decimal128.fromStringWithRounding('37.499999999999999196428571428571375')
+          ).to.not.throw();
+        });
+        context('when the digit to round is >= 5', function () {
+          it('rounds up correctly', function () {
+            const result = Decimal128.fromStringWithRounding(
+              '37.499999999999999196428571428571375'
+            );
+            expect(result.toString()).to.deep.equal('37.49999999999999919642857142857138');
+          });
+        });
+        context('when the digit to round is < 5', function () {
+          it('rounds down correctly', function () {
+            const result = Decimal128.fromStringWithRounding(
+              '37.499999999999999196428571428571374'
+            );
+            expect(result.toString()).to.deep.equal('37.49999999999999919642857142857137');
+          });
+        });
+
+        context('when the digit to round is 9', function () {
+          it('rounds up and carries correctly', function () {
+            const result = Decimal128.fromStringWithRounding(
+              '37.4999999999999999196428571428571399'
+            );
+            expect(result.toString()).to.deep.equal('37.49999999999999991964285714285714');
+          });
+        });
+      });
     });
   });
 });