Skip to content

Commit 5bcc82e

Browse files
authored
Merge pull request #2420 from apeisa/fix/stringable-sort
[3.9] Fix/stringable sort
2 parents 41a9c97 + f670c5f commit 5bcc82e

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

Diff for: src/Query/Builder.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -512,7 +512,7 @@ public function orderBy($column, $direction = 'asc')
512512
if ($column == 'natural') {
513513
$this->orders['$natural'] = $direction;
514514
} else {
515-
$this->orders[$column] = $direction;
515+
$this->orders[(string) $column] = $direction;
516516
}
517517

518518
return $this;

Diff for: tests/QueryTest.php

+11
Original file line numberDiff line numberDiff line change
@@ -239,6 +239,17 @@ public function testOrder(): void
239239
$this->assertEquals(35, $user->age);
240240
}
241241

242+
public function testStringableOrder(): void
243+
{
244+
$age = str('age');
245+
246+
$user = User::whereNotNull('age')->orderBy($age, 'asc')->first();
247+
$this->assertEquals(13, $user->age);
248+
249+
$user = User::whereNotNull('age')->orderBy($age, 'desc')->first();
250+
$this->assertEquals(37, $user->age);
251+
}
252+
242253
public function testGroupBy(): void
243254
{
244255
$users = User::groupBy('title')->get();

0 commit comments

Comments
 (0)