createOrFirst in transaction fallback to firstOrCreate

Author: GromNaN

Diff for: src/Eloquent/Builder.php

@@ -4,10 +4,10 @@
 
 namespace MongoDB\Laravel\Eloquent;
 
-use Illuminate\Database\ConnectionInterface;
 use Illuminate\Database\Eloquent\Builder as EloquentBuilder;
 use MongoDB\Driver\Cursor;
 use MongoDB\Driver\Exception\WriteException;
+use MongoDB\Laravel\Connection;
 use MongoDB\Laravel\Helpers\QueriesRelationships;
 use MongoDB\Laravel\Query\AggregationBuilder;
 use MongoDB\Model\BSONDocument;
@@ -198,8 +198,34 @@ public function raw($value = null)
         return $results;
     }
 
+    /**
+     * Get the first record matching the attributes. If the record is not found, create it.
+     *
+     * @param  array $attributes
+     * @param  array $values
+     */
+    public function firstOrCreate(array $attributes = [], array $values = []): Model|Builder
+    {
+        $instance = (clone $this)->where($attributes)->first();
+        if ($instance !== null) {
+            return $instance;
+        }
+
+        // createOrFirst is not supported in transaction.
+        if ($this->getConnection()->getSession()?->isInTransaction()) {
+            return $this->create(array_merge($attributes, $values));
+        }
+
+        return $this->createOrFirst($attributes, $values);
+    }
+
     public function createOrFirst(array $attributes = [], array $values = []): Builder|Model
     {
+        // The duplicate key error would abort the transaction. Using the regular firstOrCreate in that case.
+        if ($this->getConnection()->getSession()?->isInTransaction()) {
+            return $this->firstOrCreate($attributes, $values);
+        }
+
         try {
             return $this->create(array_merge($attributes, $values));
         } catch (WriteException $e) {
@@ -234,8 +260,7 @@ protected function addUpdatedAtColumn(array $values)
         return $values;
     }
 
-    /** @return ConnectionInterface */
-    public function getConnection()
+    public function getConnection(): Connection
     {
         return $this->query->getConnection();
     }

Diff for: tests/ModelTest.php

@@ -1048,12 +1048,19 @@ public function testNumericFieldName(): void
         $this->assertEquals([3 => 'two.three'], $found[2]);
     }
 
-    public function testCreateOrFirst()
+    #[TestWith([true])]
+    #[TestWith([false])]
+    public function testCreateOrFirst(bool $transaction)
     {
-        DB::connection('mongodb')
+        $connection = DB::connection('mongodb');
+        $connection
             ->getCollection('users')
             ->createIndex(['email' => 1], ['unique' => true]);
 
+        if ($transaction) {
+            $connection->beginTransaction();
+        }
+
         Carbon::setTestNow('2010-06-22');
         $createdAt = Carbon::now()->getTimestamp();
         $events = [];
@@ -1081,7 +1088,11 @@ public function testCreateOrFirst()
         $this->assertFalse($user2->wasRecentlyCreated);
         $this->assertEquals($createdAt, $user1->created_at->getTimestamp());
         $this->assertEquals($createdAt, $user1->updated_at->getTimestamp());
-        $this->assertEquals(['saving', 'creating'], $events);
+        if ($transaction) {
+            $this->assertEquals([], $events);
+        } else {
+            $this->assertEquals(['saving', 'creating'], $events);
+        }
 
         $events = [];
         $user3 = User::createOrFirst(
@@ -1107,6 +1118,10 @@ public function testCreateOrFirst()
         $this->assertSame('Maria Doe', $user4->name);
         $this->assertTrue($user4->wasRecentlyCreated);
         $this->assertEquals(['saving', 'creating', 'created', 'saved'], $events);
+
+        if ($transaction) {
+            $connection->commit();
+        }
     }
 
     #[TestWith([['_id' => new ObjectID()]])]