Skip to content

Commit e3f64f4

Browse files
orderBy() accept uppercase order direction
1 parent 9829d49 commit e3f64f4

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

Diff for: src/Jenssegers/Mongodb/Builder.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ public function distinct($column = false)
268268
*/
269269
public function orderBy($column, $direction = 'asc')
270270
{
271-
$this->orders[$column] = ($direction == 'asc' ? 1 : -1);
271+
$this->orders[$column] = (strtolower($direction) == 'asc' ? 1 : -1);
272272

273273
return $this;
274274
}

Diff for: tests/QueryTest.php

+3
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,9 @@ public function testOrder()
142142
$user = User::whereNotNull('age')->orderBy('age', 'asc')->first();
143143
$this->assertEquals(13, $user->age);
144144

145+
$user = User::whereNotNull('age')->orderBy('age', 'ASC')->first();
146+
$this->assertEquals(13, $user->age);
147+
145148
$user = User::whereNotNull('age')->orderBy('age', 'desc')->first();
146149
$this->assertEquals(37, $user->age);
147150
}

0 commit comments

Comments
 (0)