CDRIVER-3685 address TSAN warning for mongoc_handshake_t::frozen (#1698)

eramongodb · web-flow · commit 63b780eaa54d · 2024-08-12T13:00:15.000-05:00
diff --git a/.tsan-suppressions b/.tsan-suppressions
@@ -1,2 +1 @@
 race:mongoc_counter*
-race:_mongoc_handshake_freeze
diff --git a/src/libmongoc/src/mongoc/mongoc-handshake.c b/src/libmongoc/src/mongoc/mongoc-handshake.c
@@ -726,7 +726,9 @@ _mongoc_handshake_build_doc_with_application (const char *appname)
 void
 _mongoc_handshake_freeze (void)
 {
+   bson_mutex_lock (&gHandshakeLock);
    _mongoc_handshake_get ()->frozen = true;
+   bson_mutex_unlock (&gHandshakeLock);
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1 @@`
`1`	`1`	`race:mongoc_counter*`
`2`		`-race:_mongoc_handshake_freeze`
Original file line number	Diff line number	Diff line change
`@@ -726,7 +726,9 @@ _mongoc_handshake_build_doc_with_application (const char *appname)`
`726`	`726`	`void`
`727`	`727`	`_mongoc_handshake_freeze (void)`
`728`	`728`	`{`
	`729`	`+ bson_mutex_lock (&gHandshakeLock);`
`729`	`730`	`_mongoc_handshake_get ()->frozen = true;`
	`731`	`+ bson_mutex_unlock (&gHandshakeLock);`
`730`	`732`	`}`
`731`	`733`
`732`	`734`	`/*`