Skip to content

Commit 000e12d

Browse files
committed
Fix static analysis
1 parent c83e779 commit 000e12d

File tree

4 files changed

+34
-1
lines changed

4 files changed

+34
-1
lines changed

generator/src/OperatorClassGenerator.php

-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
use function interface_exists;
2323
use function rtrim;
2424
use function sprintf;
25-
use function var_export;
2625

2726
/**
2827
* Generates a value object class for stages and operators.

phpcs.xml.dist

+3
Original file line numberDiff line numberDiff line change
@@ -160,4 +160,7 @@
160160
<rule ref="Squiz.Classes.ValidClassName.NotCamelCaps">
161161
<exclude-pattern>/tests/SpecTests/*/Prose*</exclude-pattern>
162162
</rule>
163+
<rule ref="SlevomatCodingStandard.TypeHints.UselessConstantTypeHint.UselessDocComment">
164+
<exclude-pattern>src/Builder/Type/OperatorInterface.php</exclude-pattern>
165+
</rule>
163166
</ruleset>

psalm-baseline.xml

+30
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,12 @@
6969
<code><![CDATA[$val]]></code>
7070
<code><![CDATA[$val]]></code>
7171
</MixedAssignment>
72+
<MixedInferredReturnType>
73+
<code><![CDATA[stdClass]]></code>
74+
</MixedInferredReturnType>
75+
<MixedReturnStatement>
76+
<code><![CDATA[$result]]></code>
77+
</MixedReturnStatement>
7278
</file>
7379
<file src="src/Builder/Encoder/OutputWindowEncoder.php">
7480
<MixedArgument>
@@ -168,7 +174,26 @@
168174
<code><![CDATA[stdClass]]></code>
169175
</TooManyTemplateParams>
170176
</file>
177+
<file src="src/Builder/Type/CombinedFieldQuery.php">
178+
<MixedArgument>
179+
<code><![CDATA[$operator]]></code>
180+
<code><![CDATA[$operator]]></code>
181+
</MixedArgument>
182+
<MixedArrayOffset>
183+
<code><![CDATA[$seenOperators[$operator]]]></code>
184+
</MixedArrayOffset>
185+
<MixedAssignment>
186+
<code><![CDATA[$operator]]></code>
187+
</MixedAssignment>
188+
</file>
171189
<file src="src/Builder/Type/QueryObject.php">
190+
<MixedArgument>
191+
<code><![CDATA[$query::NAME]]></code>
192+
</MixedArgument>
193+
<MixedArrayOffset>
194+
<code><![CDATA[$seenQueryOperators[$query::NAME]]]></code>
195+
<code><![CDATA[$seenQueryOperators[$query::NAME]]]></code>
196+
</MixedArrayOffset>
172197
<MixedAssignment>
173198
<code><![CDATA[$queries[$fieldPath]]]></code>
174199
<code><![CDATA[$query]]></code>
@@ -179,6 +204,11 @@
179204
is_array($queriesOrArrayOfQueries[0]) &&
180205
count($queriesOrArrayOfQueries[0]) > 0]]></code>
181206
</RedundantConditionGivenDocblockType>
207+
<UndefinedConstant>
208+
<code><![CDATA[$query::NAME]]></code>
209+
<code><![CDATA[$query::NAME]]></code>
210+
<code><![CDATA[$query::NAME]]></code>
211+
</UndefinedConstant>
182212
</file>
183213
<file src="src/ChangeStream.php">
184214
<DeprecatedConstant>

src/Builder/Type/CombinedFieldQuery.php

+1
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ static function (array $fieldQueries, QueryInterface|FieldQueryInterface|Type|st
5757
);
5858

5959
// Validate FieldQuery types and non-duplicate operators
60+
/** @var array<string, true> $seenOperators */
6061
$seenOperators = [];
6162
foreach ($this->fieldQueries as $fieldQuery) {
6263
if ($fieldQuery instanceof stdClass) {

0 commit comments

Comments
 (0)