CLOUDP-62837: Output test results in junit format for evergreen (#182)

Author: gssbzn

.evergreen.yml

@@ -29,29 +29,30 @@ functions:
           <<: *go_options
         command: make build
   "test":
-    - command: subprocess.exec
+    - command: shell.exec
       type: test
       params:
-        add_to_path:
-          - ${go_bin}
-          - ${workdir}/bin
         working_dir: src/github.com/mongodb/mongocli
-        env:
-          GOROOT: ${go_root}
-          <<: *go_options
-        command: make test
+        script: |
+          set -o xtrace
+          set -o errexit
+          set -o verbose
+
+          export GOROOT="${go_root}"
+          export PATH="./bin:$GOROOT/bin:$PATH"
+
+          gotestsum --junitfile unit-tests.xml -- -race -cover -count=1 -coverprofile coverage.out ./internal...
   "generate html coverage":
     - command: subprocess.exec
       type: test
       params:
         add_to_path:
           - ${go_bin}
-          - ${workdir}/bin
         working_dir: src/github.com/mongodb/mongocli
         env:
           GOROOT: ${go_root}
           <<: *go_options
-        command: make coverage
+        command: go tool cover -html=coverage.out -o coverage.html
   "upload html coverage":
     - command: s3.put
       params:
@@ -71,7 +72,6 @@ functions:
           - ${go_bin}
         working_dir: src/github.com/mongodb/mongocli
         env:
-          WORKDIR: ${workdir}
           GOROOT: ${go_root}
           MCLI_OPS_MANAGER_URL: ${mcli_ops_manager_url}
           MCLI_ORG_ID: ${atlas_org_id}
@@ -89,7 +89,6 @@ functions:
           - ${go_bin}
         working_dir: src/github.com/mongodb/mongocli
         env:
-          WORKDIR: ${workdir}
           GOROOT: ${go_root}
           MCLI_OPS_MANAGER_URL: ${mcli_ops_manager_url}
           MCLI_ORG_ID: ${cloud_manager_org_id}
@@ -100,17 +99,18 @@ functions:
           <<: *go_options
         command: make e2e-test-cloud
   "lint":
-    - command: subprocess.exec
+    - command: shell.exec
       type: test
       params:
-        add_to_path:
-          - ${go_bin}
         working_dir: src/github.com/mongodb/mongocli
-        env:
-          WORKDIR: ${workdir}
-          GOROOT: ${go_root}
-          <<: *go_options
-        command: make lint
+        script: |
+          set -o xtrace
+          set -o errexit
+          set -o verbose
+
+          export GOROOT="${go_root}"
+          export PATH="./bin:$GOROOT/bin:$PATH"
+          golangci-lint run --out-format junit-xml > lint-tests.xml
   "generate notices":
     - command: shell.exec
       type: test
@@ -130,18 +130,32 @@ functions:
           popd
           cd src/github.com/mongodb/mongocli
           go-licenses save "github.com/mongodb/mongocli" --save_path=third_party_notices
-  "install gon":
+  "install gotestsum":
     - command: shell.exec
       type: setup
       params:
-        working_dir: src/github.com/mongodb/mongocli
+        working_dir: src/github.com/mongodb/mongocli/bin
         script: |
           set -o xtrace
           set -o errexit
           set -o verbose
 
-          mkdir -p bin
-          cd bin
+          curl -sfL https://github.com/gotestyourself/gotestsum/releases/download/v0.4.2/gotestsum_0.4.2_linux_amd64.tar.gz | tar zx
+  "install golangci-lint":
+    - command: subprocess.exec
+      type: setup
+      params:
+        working_dir: src/github.com/mongodb/mongocli
+        command: make setup
+  "install gon":
+    - command: shell.exec
+      type: setup
+      params:
+        working_dir: src/github.com/mongodb/mongocli/bin
+        script: |
+          set -o xtrace
+          set -o errexit
+          set -o verbose
 
           curl -sL https://github.com/mitchellh/gon/releases/download/v0.2.3/gon_macos.zip | tar zx
   "install goreleaser":
@@ -256,7 +270,7 @@ functions:
 
           env GOOS=windows GOARCH=amd64 go build -ldflags "-s -w -X github.com/mongodb/mongocli/internal/version.Version=$VERSION" -o mongocli.exe
 
-          mkdir {build,dist}
+          mkdir -p build
 
           go-msi make --msi "dist/mongocli_$VERSION.msi" --version $VERSION
   "rename pkg":
@@ -340,23 +354,40 @@ functions:
             --version ${server_version|1.0.0} \
             --arch x86_64 \
             --packages https://s3.amazonaws.com/mongodb-mongocli-build/${project}/dist/${revision}_${created_at}/${ext}.tgz
+
+post:
+  - command: attach.xunit_results
+    params:
+      files: ["src/github.com/mongodb/mongocli/*.xml"]
+
 tasks:
   - name: compile
+    tags: ["code_health"]
     commands:
       - func: "clone"
       - func: "build"
-  - name: test
+  - name: unit_test
+    tags: ["code_health"]
     commands:
       - func: "clone"
+      - func: "install gotestsum"
       - func: "test"
       - func: "generate html coverage"
       - func: "upload html coverage"
+  - name: lint
+    tags: ["code_health"]
+    commands:
+      - func: "clone"
+      - func: "install golangci-lint"
+      - func: "lint"
   - name: atlas_e2e
+    tags: ["e2e"]
     commands:
       - func: "clone"
       - func: "build"
       - func: "atlas e2e"
   - name: cloud_manager_e2e
+    tags: ["e2e"]
     commands:
       - func: "clone"
       - func: "build"
@@ -922,7 +953,8 @@ buildvariants:
       go_bin: "/opt/golang/go1.14/bin"
     tasks:
       - name: compile
-      - name: test
+      - name: unit_test
+      - name: lint
   - name: e2e
     display_name: "E2E"
     run_on:

.gitignore

@@ -4,6 +4,8 @@
 *.dll
 *.so
 *.dylib
+bin/**
+dist/**
 
 # Test binary, built with `go test -c`
 *.test
@@ -18,3 +20,4 @@ third_party_notices/
 # Evergreen generated files
 .gocache/
 gon.json
+*.xml

Makefile

@@ -6,8 +6,6 @@ BINARY_NAME=mongocli
 DESTINATION=./bin/${BINARY_NAME}
 GOLANGCI_VERSION=v1.27.0
 COVERAGE=coverage.out
-COVERAGE_HTML=coverage.html
-
 VERSION=$(shell git describe --always --tags)
 LINKER_FLAGS=-X github.com/mongodb/mongocli/internal/version.Version=${VERSION}
 
@@ -18,7 +16,6 @@ export GO111MODULE := on
 setup:  ## Install dev tools
 	@echo "==> Installing dependencies..."
 	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s $(GOLANGCI_VERSION)
-	curl -sfL https://install.goreleaser.com/github.com/goreleaser/goreleaser.sh | sh
 
 .PHONY: link-git-hooks
 link-git-hooks: ## Install git hooks
@@ -36,11 +33,6 @@ test: ## Run tests
 	@echo "==> Running tests..."
 	go test -race -cover -count=1 -coverprofile ${COVERAGE} ./internal...
 
-.PHONY: coverage
-coverage: ## Generate coverage report
-	@echo "==> generating coverage..."
-	go tool cover -html=${COVERAGE} -o ${COVERAGE_HTML}
-
 .PHONY: lint
 lint: ## Run linter
 	@echo "==> Linting all packages..."