Skip to content

CLOUDP-57529: Add short version to username and password flags #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2020
Merged

CLOUDP-57529: Add short version to username and password flags #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/cli/atlas_dbusers_create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,8 @@ func AtlasDBUsersCreateBuilder() *cobra.Command {
},
}

cmd.Flags().StringVar(&opts.username, flags.Username, "", usage.Username)
cmd.Flags().StringVar(&opts.password, flags.Password, "", usage.Password)
cmd.Flags().StringVarP(&opts.username, flags.Username, flags.UsernameShort, "", usage.Username)
cmd.Flags().StringVarP(&opts.password, flags.Password, flags.PasswordShort, "", usage.Password)
cmd.Flags().StringSliceVar(&opts.roles, flags.Role, []string{}, usage.Roles)
cmd.Flags().StringVar(&opts.authDB, flags.AuthDB, convert.AdminDB, usage.AuthDB)

Expand Down
4 changes: 2 additions & 2 deletions internal/cli/atlas_dbusers_update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@ func AtlasDBUsersUpdateBuilder() *cobra.Command {
},
}

cmd.Flags().StringVar(&opts.username, flags.Username, "", usage.Username)
cmd.Flags().StringVar(&opts.password, flags.Password, "", usage.Password)
cmd.Flags().StringVarP(&opts.username, flags.Username, flags.UsernameShort, "", usage.Username)
cmd.Flags().StringVarP(&opts.password, flags.Password, flags.PasswordShort, "", usage.Password)
cmd.Flags().StringSliceVar(&opts.roles, flags.Role, []string{}, usage.Roles)

cmd.Flags().StringVar(&opts.projectID, flags.ProjectID, "", usage.ProjectID)
Expand Down
4 changes: 2 additions & 2 deletions internal/cli/ops_manager_dbusers_create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,8 @@ func OpsManagerDBUsersCreateBuilder() *cobra.Command {
},
}

cmd.Flags().StringVar(&opts.username, flags.Username, "", usage.Username)
cmd.Flags().StringVar(&opts.password, flags.Password, "", usage.Password)
cmd.Flags().StringVarP(&opts.username, flags.Username, flags.UsernameShort, "", usage.Username)
cmd.Flags().StringVarP(&opts.password, flags.Password, flags.PasswordShort, "", usage.Password)
cmd.Flags().StringVar(&opts.authDB, flags.AuthDB, convert.AdminDB, usage.AuthDB)
cmd.Flags().StringSliceVar(&opts.roles, flags.Role, []string{}, usage.Roles)
cmd.Flags().StringSliceVar(&opts.mechanisms, flags.Mechanisms, []string{scransha1}, usage.Mechanisms)
Expand Down
2 changes: 1 addition & 1 deletion internal/cli/ops_manager_owner_create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ func OpsManagerOwnerCreateBuilder() *cobra.Command {
}

cmd.Flags().StringVar(&opts.email, flags.Email, "", usage.Email)
cmd.Flags().StringVar(&opts.password, flags.Password, "", usage.Password)
cmd.Flags().StringVarP(&opts.password, flags.Password, flags.PasswordShort, "", usage.Password)
cmd.Flags().StringVar(&opts.firstName, flags.FirstName, "", usage.FirstName)
cmd.Flags().StringVar(&opts.lastName, flags.LastName, "", usage.LastName)
cmd.Flags().StringSliceVar(&opts.whitelistIps, flags.WhitelistIP, []string{}, usage.WhitelistIps)
Expand Down
4 changes: 3 additions & 1 deletion internal/flags/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ package flags
const (
Service = "service" // Service flag to set service
Profile = "profile" // Profile flag to use a profile
ProfileShort = "p" // ProfileShort flag to use a profile
ProfileShort = "P" // ProfileShort flag to use a profile
OrgID = "orgId" // OrgID flag to use an Organization ID
ProjectID = "projectId" // ProjectID flag to use a project ID
AuthDB = "authDB" // AuthDB flag
Expand All @@ -31,7 +31,9 @@ const (
MDBVersion = "mdbVersion" // MDBVersion flag
Backup = "backup" // Backup flag
Username = "username" // Username flag
UsernameShort = "u" // UsernameShort flag
Password = "password" // Password flag
PasswordShort = "p" // PasswordShort flag
Email = "email" // Email flag
Status = "status" // Status flag
FirstName = "firstName" // FirstName flag
Expand Down