test: update unified runner ops to assert arg existence

Author: dariakp

test/tools/unified-spec-runner/operations.ts

@@ -42,7 +42,7 @@ operations.set('aggregate', async ({ entities, operation }) => {
   if (!(dbOrCollection instanceof Db || dbOrCollection instanceof Collection)) {
     throw new Error(`Operation object '${operation.object}' must be a db or collection`);
   }
-  const { pipeline, ...opts } = operation.arguments ?? {};
+  const { pipeline, ...opts } = operation.arguments!;
   const cursor = dbOrCollection.aggregate(pipeline, opts);
   return cursor.toArray();
 });
@@ -181,7 +181,7 @@ operations.set('assertNumberConnectionsCheckedOut', async ({ entities, operation
 
 operations.set('bulkWrite', async ({ entities, operation }) => {
   const collection = entities.getEntity('collection', operation.object);
-  const { requests, ...opts } = operation.arguments ?? {};
+  const { requests, ...opts } = operation.arguments!;
   return collection.bulkWrite(requests, opts);
 });
 
@@ -209,7 +209,7 @@ operations.set('createChangeStream', async ({ entities, operation }) => {
     throw new Error(`Entity ${operation.object} must be watchable`);
   }
 
-  const { pipeline, ...args } = operation.arguments ?? {};
+  const { pipeline, ...args } = operation.arguments!;
   const changeStream = watchable.watch(pipeline, args);
 
   return new Promise((resolve, reject) => {
@@ -223,13 +223,13 @@ operations.set('createChangeStream', async ({ entities, operation }) => {
 
 operations.set('createCollection', async ({ entities, operation }) => {
   const db = entities.getEntity('db', operation.object);
-  const { collection, ...opts } = operation.arguments ?? {};
+  const { collection, ...opts } = operation.arguments!;
   return await db.createCollection(collection, opts);
 });
 
 operations.set('createFindCursor', async ({ entities, operation }) => {
   const collection = entities.getEntity('collection', operation.object);
-  const { filter, ...opts } = operation.arguments ?? {};
+  const { filter, ...opts } = operation.arguments!;
   const cursor = collection.find(filter, opts);
   // The spec dictates that we create the cursor and force the find command
   // to execute, but don't move the cursor forward. hasNext() accomplishes
@@ -240,25 +240,25 @@ operations.set('createFindCursor', async ({ entities, operation }) => {
 
 operations.set('createIndex', async ({ entities, operation }) => {
   const collection = entities.getEntity('collection', operation.object);
-  const { keys, ...opts } = operation.arguments ?? {};
+  const { keys, ...opts } = operation.arguments!;
   await collection.createIndex(keys, opts);
 });
 
 operations.set('dropIndex', async ({ entities, operation }) => {
   const collection = entities.getEntity('collection', operation.object);
-  const { name, ...opts } = operation.arguments ?? {};
+  const { name, ...opts } = operation.arguments!;
   await collection.dropIndex(name, opts);
 });
 
 operations.set('deleteOne', async ({ entities, operation }) => {
   const collection = entities.getEntity('collection', operation.object);
-  const { filter, ...options } = operation.arguments ?? {};
+  const { filter, ...options } = operation.arguments!;
   return collection.deleteOne(filter, options);
 });
 
 operations.set('dropCollection', async ({ entities, operation }) => {
   const db = entities.getEntity('db', operation.object);
-  const { collection, ...opts } = operation.arguments ?? {};
+  const { collection, ...opts } = operation.arguments!;
 
   // TODO(NODE-4243): dropCollection should suppress namespace not found errors
   try {
@@ -277,25 +277,25 @@ operations.set('endSession', async ({ entities, operation }) => {
 
 operations.set('find', async ({ entities, operation }) => {
   const collection = entities.getEntity('collection', operation.object);
-  const { filter, ...opts } = operation.arguments ?? {};
+  const { filter, ...opts } = operation.arguments!;
   return collection.find(filter, opts).toArray();
 });
 
 operations.set('findOneAndReplace', async ({ entities, operation }) => {
   const collection = entities.getEntity('collection', operation.object);
-  const { filter, replacement, ...opts } = operation.arguments ?? {};
+  const { filter, replacement, ...opts } = operation.arguments!;
   return (await collection.findOneAndReplace(filter, replacement, translateOptions(opts))).value;
 });
 
 operations.set('findOneAndUpdate', async ({ entities, operation }) => {
   const collection = entities.getEntity('collection', operation.object);
-  const { filter, update, ...opts } = operation.arguments ?? {};
+  const { filter, update, ...opts } = operation.arguments!;
   return (await collection.findOneAndUpdate(filter, update, translateOptions(opts))).value;
 });
 
 operations.set('findOneAndDelete', async ({ entities, operation }) => {
   const collection = entities.getEntity('collection', operation.object);
-  const { filter, ...opts } = operation.arguments ?? {};
+  const { filter, ...opts } = operation.arguments!;
   return (await collection.findOneAndDelete(filter, opts)).value;
 });
 
@@ -306,13 +306,13 @@ operations.set('failPoint', async ({ entities, operation }) => {
 
 operations.set('insertOne', async ({ entities, operation }) => {
   const collection = entities.getEntity('collection', operation.object);
-  const { document, ...opts } = operation.arguments ?? {};
+  const { document, ...opts } = operation.arguments!;
   return collection.insertOne(document, opts);
 });
 
 operations.set('insertMany', async ({ entities, operation }) => {
   const collection = entities.getEntity('collection', operation.object);
-  const { documents, ...opts } = operation.arguments ?? {};
+  const { documents, ...opts } = operation.arguments!;
   return collection.insertMany(documents, opts);
 });
 
@@ -341,26 +341,23 @@ operations.set('iterateUntilDocumentOrError', async ({ entities, operation }) =>
 
 operations.set('listCollections', async ({ entities, operation }) => {
   const db = entities.getEntity('db', operation.object);
-  const { filter, ...opts } = operation.arguments ?? {};
+  const { filter, ...opts } = operation.arguments!;
   return db.listCollections(filter, opts).toArray();
 });
 
 operations.set('listDatabases', async ({ entities, operation }) => {
   const client = entities.getEntity('client', operation.object);
-  return client
-    .db()
-    .admin()
-    .listDatabases(operation.arguments ?? {});
+  return client.db().admin().listDatabases(operation.arguments!);
 });
 
 operations.set('listIndexes', async ({ entities, operation }) => {
   const collection = entities.getEntity('collection', operation.object);
-  return collection.listIndexes(operation.arguments ?? {}).toArray();
+  return collection.listIndexes(operation.arguments!).toArray();
 });
 
 operations.set('replaceOne', async ({ entities, operation }) => {
   const collection = entities.getEntity('collection', operation.object);
-  const { filter, replacement, ...opts } = operation.arguments ?? {};
+  const { filter, replacement, ...opts } = operation.arguments!;
   return collection.replaceOne(filter, replacement, opts);
 });
 
@@ -430,61 +427,61 @@ operations.set('withTransaction', async ({ entities, operation, client }) => {
 
 operations.set('countDocuments', async ({ entities, operation }) => {
   const collection = entities.getEntity('collection', operation.object);
-  const { filter, ...opts } = operation.arguments ?? {};
+  const { filter, ...opts } = operation.arguments!;
   return collection.countDocuments(filter, opts);
 });
 
 operations.set('deleteMany', async ({ entities, operation }) => {
   const collection = entities.getEntity('collection', operation.object);
-  const { filter, ...opts } = operation.arguments ?? {};
+  const { filter, ...opts } = operation.arguments!;
   return collection.deleteMany(filter, opts);
 });
 
 operations.set('distinct', async ({ entities, operation }) => {
   const collection = entities.getEntity('collection', operation.object);
-  const { fieldName, filter, ...opts } = operation.arguments ?? {};
+  const { fieldName, filter, ...opts } = operation.arguments!;
   return collection.distinct(fieldName, filter, opts);
 });
 
 operations.set('estimatedDocumentCount', async ({ entities, operation }) => {
   const collection = entities.getEntity('collection', operation.object);
-  return collection.estimatedDocumentCount(operation.arguments ?? {});
+  return collection.estimatedDocumentCount(operation.arguments!);
 });
 
 operations.set('runCommand', async ({ entities, operation }: OperationFunctionParams) => {
   const db = entities.getEntity('db', operation.object);
-  const { command, ...opts } = operation.arguments ?? {};
+  const { command, ...opts } = operation.arguments!;
   return db.command(command, opts);
 });
 
 operations.set('updateMany', async ({ entities, operation }) => {
   const collection = entities.getEntity('collection', operation.object);
-  const { filter, update, ...options } = operation.arguments ?? {};
+  const { filter, update, ...options } = operation.arguments!;
   return collection.updateMany(filter, update, options);
 });
 
 operations.set('updateOne', async ({ entities, operation }) => {
   const collection = entities.getEntity('collection', operation.object);
-  const { filter, update, ...options } = operation.arguments ?? {};
+  const { filter, update, ...options } = operation.arguments!;
   return collection.updateOne(filter, update, options);
 });
 
 operations.set('rename', async ({ entities, operation }) => {
   const collection = entities.getEntity('collection', operation.object);
-  const { to, ...options } = operation.arguments ?? {};
+  const { to, ...options } = operation.arguments!;
   return collection.rename(to, options);
 });
 
 operations.set('createDataKey', async ({ entities, operation }) => {
   const clientEncryption = entities.getEntity('clientEncryption', operation.object);
-  const { kmsProvider, opts } = operation.arguments ?? {};
+  const { kmsProvider, opts } = operation.arguments!;
 
   return clientEncryption.createDataKey(kmsProvider, opts);
 });
 
 operations.set('rewrapManyDataKey', async ({ entities, operation }) => {
   const clientEncryption = entities.getEntity('clientEncryption', operation.object);
-  const { filter, opts } = operation.arguments ?? {};
+  const { filter, opts } = operation.arguments!;
 
   const rewrapManyDataKeyResult = await clientEncryption.rewrapManyDataKey(filter, opts);
 
@@ -506,14 +503,14 @@ operations.set('rewrapManyDataKey', async ({ entities, operation }) => {
 
 operations.set('deleteKey', async ({ entities, operation }) => {
   const clientEncryption = entities.getEntity('clientEncryption', operation.object);
-  const { id } = operation.arguments ?? {};
+  const { id } = operation.arguments!;
 
   return clientEncryption.deleteKey(id);
 });
 
 operations.set('getKey', async ({ entities, operation }) => {
   const clientEncryption = entities.getEntity('clientEncryption', operation.object);
-  const { id } = operation.arguments ?? {};
+  const { id } = operation.arguments!;
 
   return clientEncryption.getKey(id);
 });
@@ -526,21 +523,21 @@ operations.set('getKeys', async ({ entities, operation }) => {
 
 operations.set('addKeyAltName', async ({ entities, operation }) => {
   const clientEncryption = entities.getEntity('clientEncryption', operation.object);
-  const { id, keyAltName } = operation.arguments ?? {};
+  const { id, keyAltName } = operation.arguments!;
 
   return clientEncryption.addKeyAltName(id, keyAltName);
 });
 
 operations.set('removeKeyAltName', async ({ entities, operation }) => {
   const clientEncryption = entities.getEntity('clientEncryption', operation.object);
-  const { id, keyAltName } = operation.arguments ?? {};
+  const { id, keyAltName } = operation.arguments!;
 
   return clientEncryption.removeKeyAltName(id, keyAltName);
 });
 
 operations.set('getKeyByAltName', async ({ entities, operation }) => {
   const clientEncryption = entities.getEntity('clientEncryption', operation.object);
-  const { keyAltName } = operation.arguments ?? {};
+  const { keyAltName } = operation.arguments!;
 
   return clientEncryption.getKeyByAltName(keyAltName);
 });