Skip to content

feat(NODE-2938): add service host mechanism property #3130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 10, 2022
Merged

feat(NODE-2938): add service host mechanism property #3130

merged 5 commits into from
Feb 10, 2022

Conversation

durran
Copy link
Member

@durran durran commented Feb 4, 2022

Description

Adds a SERVICE_HOST property to auth mechanisms for the kerberos auth case where a different host in the service principal name should be provided instead of the resolved host.

What is changing?

Adds a SERVICE_HOST property and updates the tests to include it.

This branch is rebased against #3122

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-2938

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 8, 2022
@durran durran force-pushed the NODE-2938-gssapi-service-host branch from 747528b to 1db60e7 Compare February 9, 2022 12:26
@dariakp dariakp self-assigned this Feb 9, 2022
dariakp
dariakp requested changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small test adjustment here

@dariakp dariakp added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Feb 9, 2022
nbbeeken
nbbeeken previously approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Daria's nits, but LGTM otherwise

@durran durran force-pushed the NODE-2938-gssapi-service-host branch from 1db60e7 to f0acf9c Compare February 9, 2022 20:55
@durran durran requested a review from dariakp February 9, 2022 20:56
dariakp
dariakp previously approved these changes Feb 9, 2022
View reviewed changes
@durran durran force-pushed the NODE-2938-gssapi-service-host branch from f0acf9c to 1c3932b Compare February 9, 2022 21:07
baileympearson
baileympearson previously approved these changes Feb 9, 2022
View reviewed changes
dariakp
dariakp requested changes Feb 9, 2022
View reviewed changes
@durran durran requested a review from dariakp February 10, 2022 13:36
dariakp
dariakp requested changes Feb 10, 2022
View reviewed changes
@durran durran requested a review from dariakp February 10, 2022 17:36
@dariakp dariakp merged commit 46d5821 into main Feb 10, 2022
@dariakp dariakp deleted the NODE-2938-gssapi-service-host branch February 10, 2022 20:20
@dariakp dariakp mentioned this pull request Feb 10, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken left review comments

@dariakp dariakp dariakp approved these changes

@baileympearson baileympearson baileympearson left review comments

Assignees

@dariakp dariakp

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@durran @nbbeeken @baileympearson @dariakp