fix(NODE-4429): select server sync for endSessions during close #3363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
added
the
Primary Review
durran
commented
Aug 16, 2022
nbbeeken
requested changes
Aug 16, 2022
nbbeeken
previously approved these changes
Aug 16, 2022
nbbeeken
added
Team Review
dariakp
requested changes
Aug 16, 2022
dariakp
approved these changes
Aug 17, 2022
baileympearson
approved these changes
Aug 17, 2022
nbbeeken
approved these changes
Aug 17, 2022
nbbeeken
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This prevents the
endSessionscommand from going through server selection when no server would be selected after callingclient.close(). This could happen in situations where the server has gone down but server selection keeps forcing monitor checks for up toserverSelectionTimeoutMSwhen an immediate return is desired.What is changing?
MongoClient'sclose()method now does a quick server selection to get the list of servers that would be returned with a primary preferred read preference. If nothing is returned then callingendSessionsis skipped.Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-4429
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>