Skip to content

feat(NODE-4815): stringify and truncate BSON documents in log messages #3635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 18, 2023
Merged

feat(NODE-4815): stringify and truncate BSON documents in log messages #3635

merged 3 commits into from
Apr 18, 2023

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Apr 12, 2023 •
edited
Loading

Description

What is changing?

Adds the maybeTruncate helper and calls it in the defaultLogTransform helper function to produce spec-compliant logs.

Is there new documentation needed for these changes?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James changed the title start testing feat(NODE-4815): stringify and truncate BSON documents in log messages Apr 12, 2023
@W-A-James W-A-James changed the base branch from NODE-4813/Implement_severity_logging_methods to NODE-4814/implement_remaining_severity_logging_methods April 12, 2023 19:20
@W-A-James W-A-James force-pushed the NODE-4815/stringify_and_truncate_BSON_responses branch 2 times, most recently from fd8d964 to 5d94624 Compare April 12, 2023 19:24
@W-A-James W-A-James force-pushed the NODE-4814/implement_remaining_severity_logging_methods branch 3 times, most recently from ab7b362 to c2324c9 Compare April 14, 2023 20:19
@W-A-James W-A-James changed the base branch from NODE-4814/implement_remaining_severity_logging_methods to main April 14, 2023 20:20
@W-A-James W-A-James force-pushed the NODE-4815/stringify_and_truncate_BSON_responses branch from 29d6e19 to cc60084 Compare April 14, 2023 20:42
@W-A-James W-A-James marked this pull request as ready for review April 14, 2023 20:49
@nbbeeken nbbeeken self-assigned this Apr 18, 2023
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Apr 18, 2023
nbbeeken
nbbeeken requested changes Apr 18, 2023
View reviewed changes
@W-A-James W-A-James requested a review from nbbeeken April 18, 2023 20:29
nbbeeken
nbbeeken approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Apr 18, 2023
@nbbeeken nbbeeken merged commit d6bd1d1 into main Apr 18, 2023
@nbbeeken nbbeeken deleted the NODE-4815/stringify_and_truncate_BSON_responses branch April 18, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@nbbeeken nbbeeken

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@W-A-James @nbbeeken