Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-5940): cache the AWS credentials provider in the MONGODB-AWS auth logic #4000

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Feb 23, 2024

Description

Instead of creating a new AWS provider for each authentication, we cache the AWS credentials provider per client.

What is changing?

Backporting NODE-5616 to 5.x.

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-5940

Release Highlight

Caching AWS credentials provider per client

Instead of creating a new AWS provider for each authentication, we cache the AWS credentials provider per client to prevent overwhelming the auth endpoint and ensure that cached credentials are not shared with other clients.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@alenakhineika alenakhineika marked this pull request as ready for review February 23, 2024 15:57
@nbbeeken nbbeeken self-requested a review February 23, 2024 17:16
@nbbeeken nbbeeken self-assigned this Feb 23, 2024
@nbbeeken nbbeeken changed the title feat(NODE-5940): Backport 5.x: Cache the AWS credentials provider in the MONGODB-AWS auth logic feat(NODE-5940): cache the AWS credentials provider in the MONGODB-AWS auth logic Feb 23, 2024
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a straightforward backport, small test fix

@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 23, 2024
@alenakhineika alenakhineika added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Feb 27, 2024
@nbbeeken nbbeeken merged commit 60bfc48 into 5.x Feb 28, 2024
20 of 27 checks passed
@nbbeeken nbbeeken deleted the NODE-5940-cache-aws-credentials-5x branch February 28, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants