Skip to content

perf(NODE-6452): Optimize CommandStartedEvent and CommandSucceededEvent constructors #4371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 17, 2025
Merged

perf(NODE-6452): Optimize CommandStartedEvent and CommandSucceededEvent constructors #4371

merged 7 commits into from
Jan 17, 2025

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Jan 15, 2025 •
edited
Loading

Description

What is changing?

  • Remove deep copy from extractCommand and extractReply helpers
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Improving performance of command monitoring

Release Highlight

Improve command monitoring performance

Eliminated unnecessary deep copies of command and reply objects when command monitoring is enabled.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James mentioned this pull request Jan 15, 2025
Closed
5 tasks
@W-A-James W-A-James marked this pull request as ready for review January 16, 2025 16:59
@nbbeeken nbbeeken self-assigned this Jan 16, 2025
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jan 16, 2025
@nbbeeken nbbeeken self-requested a review January 16, 2025 17:53
@W-A-James W-A-James requested a review from nbbeeken January 16, 2025 22:07
nbbeeken
nbbeeken approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbbeeken nbbeeken merged commit 41b066b into main Jan 17, 2025
30 checks passed
@nbbeeken nbbeeken deleted the NODE-6452-spreading branch January 17, 2025 23:16
@github-actions github-actions bot mentioned this pull request Jan 17, 2025
Merged
W-A-James added a commit that referenced this pull request Jan 22, 2025
@W-A-James
perf(NODE-6452): Optimize CommandStartedEvent and CommandSucceededEve…
d21c4ff 
…nt constructors (#4371)
W-A-James added a commit that referenced this pull request Jan 27, 2025
@W-A-James
perf(NODE-6452): Optimize CommandStartedEvent and CommandSucceededEve…
312aafc 
…nt constructors (#4371)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@nbbeeken nbbeeken

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@W-A-James @nbbeeken