Skip to content

test(NODE-3596): update max staleness spec tests #3016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2021
Merged

test(NODE-3596): update max staleness spec tests #3016

merged 2 commits into from
Oct 26, 2021

Conversation

durran
Copy link
Member

@durran durran commented Oct 26, 2021

Description

Updates the max staleness spec tests to the latest with the maxWireVersion updates.

What is changing?

The spec tests in the max staleness tests update maxWireVersion to 6. #3014 is related.

Is there new documentation needed for these changes?

No

What is the motivation for this change?

With the minimum wire version of the driver changing to 6, these tests needed to be updated.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests

@dariakp dariakp self-assigned this Oct 26, 2021
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 26, 2021
@dariakp dariakp self-requested a review October 26, 2021 20:18
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus the one questionable test change

@dariakp dariakp merged commit 1d696a4 into main Oct 26, 2021
@dariakp dariakp deleted the NODE-3596 branch October 26, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants