Skip to content

Commit 4ff68c6

Browse files
committed
rename enum to bool
1 parent e55349f commit 4ff68c6

6 files changed

+22
-25
lines changed

source/unified-test-format/schema-1.7.json

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -220,10 +220,7 @@
220220
"enum": ["command", "cmap"]
221221
},
222222
"events": { "type": "array" },
223-
"eventMatch": {
224-
"type": "string",
225-
"enum": ["exact", "prefix"]
226-
}
223+
"ignoreExtraEvents": { "type": "boolean" }
227224
},
228225
"oneOf": [
229226
{

source/unified-test-format/tests/invalid/expectedEventsForClient-eventMatch.json renamed to source/unified-test-format/tests/invalid/expectedEventsForClient-ignoreExtraEvents-type.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"description": "expectedEventsForClient-additionalProperties",
2+
"description": "expectedEventsForClient-ignoreExtraEvents-type",
33
"schemaVersion": "1.7",
44
"createEntities": [
55
{
@@ -16,7 +16,7 @@
1616
{
1717
"client": "client0",
1818
"events": [],
19-
"eventMatch": 0
19+
"ignoreExtraEvents": 0
2020
}
2121
]
2222
}

source/unified-test-format/tests/invalid/expectedEventsForClient-eventMatch.yml renamed to source/unified-test-format/tests/invalid/expectedEventsForClient-ignoreExtraEvents-type.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
description: "expectedEventsForClient-additionalProperties"
1+
description: "expectedEventsForClient-ignoreExtraEvents-type"
22

33
schemaVersion: "1.7"
44

@@ -12,4 +12,4 @@ tests:
1212
expectEvents:
1313
- client: *client0
1414
events: []
15-
eventMatch: 0
15+
ignoreExtraEvents: 0

source/unified-test-format/tests/valid-pass/expectedEventsForClient-eventMatch.json renamed to source/unified-test-format/tests/valid-pass/expectedEventsForClient-ignoreExtraEvents.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"description": "expectedEventsForClient-eventType",
2+
"description": "expectedEventsForClient-ignoreExtraEvents",
33
"schemaVersion": "1.7",
44
"createEntities": [
55
{
@@ -35,7 +35,7 @@
3535
],
3636
"tests": [
3737
{
38-
"description": "eventMatch can be set to exact",
38+
"description": "ignoreExtraEvents can be set to false",
3939
"operations": [
4040
{
4141
"name": "insertOne",
@@ -50,7 +50,7 @@
5050
"expectEvents": [
5151
{
5252
"client": "client0",
53-
"eventMatch": "exact",
53+
"ignoreExtraEvents": false,
5454
"events": [
5555
{
5656
"commandStartedEvent": {
@@ -70,7 +70,7 @@
7070
]
7171
},
7272
{
73-
"description": "eventMatch can be set to prefix",
73+
"description": "ignoreExtraEvents can be set to true",
7474
"operations": [
7575
{
7676
"name": "insertOne",
@@ -94,7 +94,7 @@
9494
"expectEvents": [
9595
{
9696
"client": "client0",
97-
"eventMatch": "prefix",
97+
"ignoreExtraEvents": true,
9898
"events": [
9999
{
100100
"commandStartedEvent": {
@@ -114,7 +114,7 @@
114114
]
115115
},
116116
{
117-
"description": "eventMatch defaults to exact if unset",
117+
"description": "ignoreExtraEvents defaults to false if unset",
118118
"operations": [
119119
{
120120
"name": "insertOne",

source/unified-test-format/tests/valid-pass/expectedEventsForClient-eventMatch.yml renamed to source/unified-test-format/tests/valid-pass/expectedEventsForClient-ignoreExtraEvents.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
description: expectedEventsForClient-eventType
1+
description: expectedEventsForClient-ignoreExtraEvents
22

33
schemaVersion: '1.7'
44

@@ -23,15 +23,15 @@ initialData:
2323
documents: []
2424

2525
tests:
26-
- description: eventMatch can be set to exact
26+
- description: ignoreExtraEvents can be set to false
2727
operations:
2828
- name: insertOne
2929
object: *collection0
3030
arguments:
3131
document: &insertDocument1 { _id: 1 }
3232
expectEvents:
3333
- client: *client0
34-
eventMatch: exact
34+
ignoreExtraEvents: false
3535
events:
3636
- commandStartedEvent:
3737
command:
@@ -40,7 +40,7 @@ tests:
4040
- *insertDocument1
4141
commandName: insert
4242

43-
- description: eventMatch can be set to prefix
43+
- description: ignoreExtraEvents can be set to true
4444
operations:
4545
- name: insertOne
4646
object: *collection0
@@ -52,7 +52,7 @@ tests:
5252
document: { _id: 3 }
5353
expectEvents:
5454
- client: *client0
55-
eventMatch: prefix
55+
ignoreExtraEvents: true
5656
events:
5757
- commandStartedEvent:
5858
command:
@@ -61,7 +61,7 @@ tests:
6161
- *insertDocument2
6262
commandName: insert
6363

64-
- description: eventMatch defaults to exact if unset
64+
- description: ignoreExtraEvents defaults to false if unset
6565
operations:
6666
- name: insertOne
6767
object: *collection0

source/unified-test-format/unified-test-format.rst

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1006,11 +1006,11 @@ The structure of each object is as follows:
10061006
executing `operations`_. If the array is empty, the test runner MUST assert
10071007
that no events were observed on the client (excluding ignored events).
10081008

1009-
- ``eventMatch``: Optional string. Specifies how the ``events`` array is
1010-
matched against the observed events. Valid values are ``exact``, meaning
1011-
that observed events after all specified events have matched MUST cause a
1012-
test failure, and ``prefix``, meaning that observed events after all
1013-
specified events have been matched MUST NOT cause a test failure.
1009+
- ``ignoreExtraEvents``: Optional boolean. Specifies how the ``events`` array
1010+
is matched against the observed events. If ``false``, observed events after
1011+
all specified events have matched MUST cause a test failure; if ``true``,
1012+
observed events after all specified events have been matched MUST NOT cause a
1013+
test failure. Defaults to ``false``.
10141014

10151015

10161016
expectedEvent

0 commit comments

Comments
 (0)