chore: Adds import checks to tests (#3039)

* chore: removed unused ctx

* test: Add import checks to all test cases

* ignore replication_specs in import verification

* test: Add mongo_db_major_version to ignored fields in TestStepImportCluster

* chore: Updates mock files to include import step

* test: Add state_name to ignored fields in TestStepImportCluster to prevent flaky tests

* test: Add id to ignored fields in TestStepImportCluster to prevent flaky tests

Author: EspenAlbert

internal/service/advancedcluster/resource_advanced_cluster_test.go

@@ -166,6 +166,7 @@ func TestAccMockableAdvancedCluster_tenantUpgrade(t *testing.T) {
 				Config: acc.ConvertAdvancedClusterToSchemaV2(t, true, configTenantUpgraded(projectID, clusterName, defaultZoneName)),
 				Check:  checksTenantUpgraded(projectID, clusterName),
 			},
+			acc.TestStepImportCluster(resourceName),
 		},
 	})
 }
@@ -358,6 +359,7 @@ func TestAccClusterAdvancedCluster_advancedConfig_oldMongoDBVersion(t *testing.T
 				Config: configAdvanced(t, true, projectID, clusterName, "6.0", processArgs20240530, processArgsCipherConfig),
 				Check:  checkAdvanced(true, clusterName, "TLS1_2", processArgsCipherConfig),
 			},
+			acc.TestStepImportCluster(resourceName),
 		},
 	})
 }
@@ -425,6 +427,7 @@ func TestAccClusterAdvancedCluster_advancedConfig(t *testing.T) {
 				Config: configAdvanced(t, true, projectID, clusterNameUpdated, "", processArgs20240530Updated, processArgsUpdatedCipherConfig),
 				Check:  checkAdvanced(true, clusterNameUpdated, "TLS1_2", processArgsUpdatedCipherConfig),
 			},
+			acc.TestStepImportCluster(resourceName),
 		},
 	})
 }
@@ -469,6 +472,7 @@ func TestAccClusterAdvancedCluster_defaultWrite(t *testing.T) {
 				Config: configAdvancedDefaultWrite(t, true, projectID, clusterNameUpdated, processArgsUpdated),
 				Check:  checkAdvancedDefaultWrite(true, clusterNameUpdated, "majority", "TLS1_2"),
 			},
+			acc.TestStepImportCluster(resourceName),
 		},
 	})
 }
@@ -511,6 +515,7 @@ func TestAccClusterAdvancedClusterConfig_replicationSpecsAutoScaling(t *testing.
 					acc.TestCheckResourceAttrSchemaV2(true, resourceName, "replication_specs.0.region_configs.0.auto_scaling.0.compute_enabled", "true"),
 				),
 			},
+			acc.TestStepImportCluster(resourceName),
 		},
 	})
 }
@@ -552,6 +557,7 @@ func TestAccClusterAdvancedClusterConfig_replicationSpecsAnalyticsAutoScaling(t
 					acc.TestCheckResourceAttrSchemaV2(true, resourceName, "replication_specs.0.region_configs.0.analytics_auto_scaling.0.compute_enabled", "true"),
 				),
 			},
+			acc.TestStepImportCluster(resourceName),
 		},
 	})
 }
@@ -568,6 +574,7 @@ func TestAccClusterAdvancedClusterConfig_singleShardedTransitionToOldSchemaExpec
 				Config: configGeoShardedOldSchema(t, true, projectID, clusterName, 1, 1, false),
 				Check:  checkGeoShardedOldSchema(true, clusterName, 1, 1, true, true),
 			},
+			acc.TestStepImportCluster(resourceName),
 			{
 				Config:      configGeoShardedOldSchema(t, true, projectID, clusterName, 1, 2, false),
 				ExpectError: regexp.MustCompile(advancedcluster.ErrorOperationNotPermitted),
@@ -600,6 +607,7 @@ func TestAccClusterAdvancedCluster_withTags(t *testing.T) {
 				Config: configWithKeyValueBlocks(t, true, orgID, projectName, clusterName, "tags", acc.ClusterTagsMap3),
 				Check:  checkKeyValueBlocks(true, true, "tags", acc.ClusterTagsMap3),
 			},
+			acc.TestStepImportCluster(resourceName),
 		},
 	})
 }
@@ -628,6 +636,7 @@ func TestAccClusterAdvancedCluster_withLabels(t *testing.T) {
 				Config: configWithKeyValueBlocks(t, true, orgID, projectName, clusterName, "labels", acc.ClusterLabelsMap3),
 				Check:  checkKeyValueBlocks(true, true, "labels", acc.ClusterLabelsMap3),
 			},
+			acc.TestStepImportCluster(resourceName),
 		},
 	})
 }
@@ -671,6 +680,7 @@ func TestAccClusterAdvancedClusterConfig_selfManagedSharding(t *testing.T) {
 				Check: resource.ComposeAggregateTestCheckFunc(checks...,
 				),
 			},
+			acc.TestStepImportCluster(resourceName),
 			{
 				Config:      configGeoShardedOldSchema(t, true, projectID, clusterName, 1, 1, false),
 				ExpectError: regexp.MustCompile("CANNOT_MODIFY_GLOBAL_CLUSTER_MANAGEMENT_SETTING"),
@@ -715,6 +725,7 @@ func TestAccMockableAdvancedCluster_symmetricShardedOldSchema(t *testing.T) {
 				Config: configShardedOldSchemaMultiCloud(t, true, projectID, clusterName, 2, "M20", &configServerManagementModeAtlasManaged),
 				Check:  checkShardedOldSchemaMultiCloud(true, clusterName, 2, "M20", false, &configServerManagementModeAtlasManaged),
 			},
+			acc.TestStepImportCluster(resourceName, "replication_specs"), // Import with old schema will NOT use `num_shards`
 		},
 	})
 }
@@ -744,6 +755,7 @@ func symmetricGeoShardedOldSchemaTestCase(t *testing.T, isAcc bool) resource.Tes
 					checkGeoShardedOldSchema(isAcc, clusterName, 3, 3, true, false),
 					acc.CheckIndependentShardScalingMode(resourceName, clusterName, "CLUSTER")),
 			},
+			acc.TestStepImportCluster(resourceName, "replication_specs"), // Import with old schema will NOT use `num_shards`
 		},
 	}
 }
@@ -764,6 +776,7 @@ func TestAccMockableAdvancedCluster_symmetricShardedOldSchemaDiskSizeGBAtElectab
 				Config: configShardedOldSchemaDiskSizeGBElectableLevel(t, true, projectID, clusterName, 55),
 				Check:  checkShardedOldSchemaDiskSizeGBElectableLevel(true, 55),
 			},
+			acc.TestStepImportCluster(resourceName, "replication_specs"), // Import with old schema will NOT use `num_shards`
 		},
 	})
 }
@@ -792,6 +805,7 @@ func TestAccClusterAdvancedClusterConfig_symmetricShardedNewSchemaToAsymmetricAd
 				Config: configShardedNewSchema(t, true, orgID, projectName, clusterName, 55, "M10", "M20", nil, nil, false, false), // removes middle replication spec
 				Check:  checkShardedNewSchema(true, 55, "M10", "M20", nil, nil, true, false),
 			},
+			acc.TestStepImportCluster(resourceName),
 		},
 	})
 }
@@ -820,6 +834,7 @@ func asymmetricShardedNewSchemaTestCase(t *testing.T, isAcc bool) resource.TestC
 					resource.TestCheckResourceAttr("data.mongodbatlas_advanced_clusters.test-replication-specs-per-shard-false", "results.#", "0"),
 					acc.CheckIndependentShardScalingMode(resourceName, clusterName, "SHARD")),
 			},
+			acc.TestStepImportCluster(resourceName),
 		},
 	}
 }
@@ -863,6 +878,7 @@ func TestAccClusterAdvancedClusterConfig_asymmetricGeoShardedNewSchemaAddingRemo
 				Config: configGeoShardedNewSchema(t, true, projectID, clusterName, false),
 				Check:  checkGeoShardedNewSchema(true, false),
 			},
+			acc.TestStepImportCluster(resourceName),
 		},
 	})
 }
@@ -885,6 +901,7 @@ func TestAccClusterAdvancedClusterConfig_shardedTransitionFromOldToNewSchema(t *
 				Config: configShardedTransitionOldToNewSchema(t, true, projectID, clusterName, true, false),
 				Check:  checkShardedTransitionOldToNewSchema(true, true),
 			},
+			acc.TestStepImportCluster(resourceName),
 		},
 	})
 }
@@ -905,6 +922,7 @@ func TestAccClusterAdvancedClusterConfig_geoShardedTransitionFromOldToNewSchema(
 				Config: configGeoShardedTransitionOldToNewSchema(t, true, projectID, clusterName, true),
 				Check:  checkGeoShardedTransitionOldToNewSchema(true, true),
 			},
+			acc.TestStepImportCluster(resourceName),
 		},
 	})
 }
@@ -937,6 +955,7 @@ func TestAccAdvancedCluster_replicaSetScalingStrategyAndRedactClientLogData(t *t
 				Config: configReplicaSetScalingStrategyAndRedactClientLogData(t, true, orgID, projectName, clusterName, "NODE_TYPE", false),
 				Check:  checkReplicaSetScalingStrategyAndRedactClientLogData(true, "NODE_TYPE", false),
 			},
+			acc.TestStepImportCluster(resourceName),
 		},
 	})
 }
@@ -965,6 +984,7 @@ func TestAccAdvancedCluster_replicaSetScalingStrategyAndRedactClientLogDataOldSc
 				Config: configReplicaSetScalingStrategyAndRedactClientLogDataOldSchema(t, true, orgID, projectName, clusterName, "NODE_TYPE", false),
 				Check:  checkReplicaSetScalingStrategyAndRedactClientLogData(true, "NODE_TYPE", false),
 			},
+			acc.TestStepImportCluster(resourceName, "replication_specs"), // Import with old schema will NOT use `num_shards`
 		},
 	})
 }
@@ -994,6 +1014,7 @@ func TestAccClusterAdvancedCluster_priorityOldSchema(t *testing.T) {
 				Config: configPriority(t, true, projectID, clusterName, true, false),
 				Check:  acc.TestCheckResourceAttrSchemaV2(true, resourceName, "replication_specs.0.region_configs.#", "2"),
 			},
+			acc.TestStepImportCluster(resourceName, "replication_specs"), // Import with old schema will NOT use `num_shards`
 		},
 	})
 }
@@ -1044,6 +1065,7 @@ func TestAccClusterAdvancedCluster_biConnectorConfig(t *testing.T) {
 				Config: configBiConnectorConfig(t, true, projectID, clusterName, true),
 				Check:  checkTenantBiConnectorConfig(true, projectID, clusterName, true),
 			},
+			acc.TestStepImportCluster(resourceName),
 		},
 	})
 }
@@ -1096,6 +1118,7 @@ func TestAccClusterAdvancedCluster_pinnedFCVWithVersionUpgradeAndDowngrade(t *te
 				Config: configFCVPinning(t, orgID, projectName, clusterName, nil, "7.0"),
 				Check:  acc.CheckFCVPinningConfig(true, resourceName, dataSourceName, dataSourcePluralName, 7, nil, nil),
 			},
+			acc.TestStepImportCluster(resourceName),
 		},
 	})
 }
@@ -1116,6 +1139,7 @@ func TestAccAdvancedCluster_oldToNewSchemaWithAutoscalingEnabled(t *testing.T) {
 				Config: configShardedTransitionOldToNewSchema(t, true, projectID, clusterName, true, true),
 				Check:  acc.CheckIndependentShardScalingMode(resourceName, clusterName, "SHARD"),
 			},
+			acc.TestStepImportCluster(resourceName),
 		},
 	})
 }
@@ -1140,6 +1164,7 @@ func TestAccAdvancedCluster_oldToNewSchemaWithAutoscalingDisabledToEnabled(t *te
 				Config: configShardedTransitionOldToNewSchema(t, true, projectID, clusterName, true, true),
 				Check:  acc.CheckIndependentShardScalingMode(resourceName, clusterName, "SHARD"),
 			},
+			acc.TestStepImportCluster(resourceName),
 		},
 	})
 }