Latest

Author: mattgperry

dev/html/public/playwright/animate/animate-cancel.html

@@ -51,9 +51,13 @@
             mini.finished.then(() => {
                 miniElement.innerHTML = "finished"
             })
-            js.finished.then(() => {
-                jsElement.innerHTML = "finished"
-            })
+            js.finished
+                .then(() => {
+                    jsElement.innerHTML = "finished"
+                })
+                .catch(() => {
+                    console.log("js rejected")
+                })
             waapi.finished.then(() => {
                 waapiElement.innerHTML = "finished"
             })

dev/html/public/playwright/animate/animate-stop.html

@@ -44,16 +44,26 @@
                 options
             )
 
-            mini.finished.then(() => {
+            mini.then(() => {
                 document.getElementById("mini").innerHTML = "finished"
             })
-            js.finished.then(() => {
+            js.then(() => {
                 document.getElementById("js").innerHTML = "finished"
             })
-            waapi.finished.then(() => {
+            waapi.then(() => {
                 document.getElementById("waapi").innerHTML = "finished"
             })
 
+            // mini.finished.then(() => {
+            //     document.getElementById("mini").innerHTML = "finished"
+            // })
+            // js.finished.then(() => {
+            //     document.getElementById("js").innerHTML = "finished"
+            // })
+            // waapi.finished.then(() => {
+            //     document.getElementById("waapi").innerHTML = "finished"
+            // })
+
             delay(() => {
                 mini.stop()
                 js.stop()

packages/motion-dom/src/animation/GroupAnimationWithThen.ts

@@ -1,3 +1,4 @@
+import { noop } from "motion-utils"
 import { GroupAnimation } from "./GroupAnimation"
 import { AnimationPlaybackControlsWithThen } from "./types"
 
@@ -6,6 +7,11 @@ export class GroupAnimationWithThen
     implements AnimationPlaybackControlsWithThen
 {
     then(onResolve: VoidFunction, _onReject?: VoidFunction) {
-        return this.finished.finally(onResolve).then(() => {})
+        return this.finished
+            .then(() => {
+                onResolve()
+                console.log("onResolve")
+            })
+            .catch(noop)
     }
 }

packages/motion-dom/src/animation/__tests__/JSAnimation.test.ts

@@ -88,7 +88,7 @@ describe("JSAnimation", () => {
                 onUpdate: (v) => numeric.push(v),
                 onComplete: () => {
                     expect(numeric).toEqual([0, 40, 80, 120, 160, 200])
-
+                    console.log("first animation complete")
                     animateValue({
                         driver: syncDriver(20),
                         duration: 100,