Refactored 'logs' command (scaleway#80)

Author: moul

pkg/cli/logs.go

@@ -5,12 +5,9 @@
 package cli
 
 import (
-	"os"
+	"github.com/scaleway/scaleway-cli/vendor/github.com/Sirupsen/logrus"
 
-	log "github.com/scaleway/scaleway-cli/vendor/github.com/Sirupsen/logrus"
-
-	"github.com/scaleway/scaleway-cli/pkg/api"
-	"github.com/scaleway/scaleway-cli/pkg/utils"
+	"github.com/scaleway/scaleway-cli/pkg/commands"
 )
 
 var cmdLogs = &Command{
@@ -29,39 +26,21 @@ func init() {
 var logsHelp bool      // -h, --help flag
 var logsGateway string // -g, --gateway flag
 
-func runLogs(cmd *Command, args []string) {
+func runLogs(cmd *Command, rawArgs []string) {
 	if logsHelp {
 		cmd.PrintUsage()
 	}
-	if len(args) != 1 {
+	if len(rawArgs) != 1 {
 		cmd.PrintShortUsage()
 	}
 
-	serverID := cmd.API.GetServerID(args[0])
-	server, err := cmd.API.GetServer(serverID)
-	if err != nil {
-		log.Fatalf("Failed to get server information for %s: %v", serverID, err)
+	args := commands.LogsArgs{
+		Gateway: logsGateway,
+		Server:  rawArgs[0],
 	}
-
-	// FIXME: switch to serial history when API is ready
-
-	// Resolve gateway
-	if logsGateway == "" {
-		logsGateway = os.Getenv("SCW_GATEWAY")
-	}
-	var gateway string
-	if logsGateway == serverID || logsGateway == args[0] {
-		gateway = ""
-	} else {
-		gateway, err = api.ResolveGateway(cmd.API, logsGateway)
-		if err != nil {
-			log.Fatalf("Cannot resolve Gateway '%s': %v", logsGateway, err)
-		}
-	}
-
-	command := []string{"dmesg"}
-	err = utils.SSHExec(server.PublicAddress.IP, server.PrivateIP, command, true, gateway)
+	ctx := cmd.GetContext(rawArgs)
+	err := commands.RunLogs(ctx, args)
 	if err != nil {
-		log.Fatalf("Command execution failed: %v", err)
+		logrus.Fatalf("Cannot execute 'logs': %v", err)
 	}
 }

pkg/commands/logs.go

@@ -0,0 +1,50 @@
+// Copyright (C) 2015 Scaleway. All rights reserved.
+// Use of this source code is governed by a MIT-style
+// license that can be found in the LICENSE.md file.
+
+package commands
+
+import (
+	"fmt"
+
+	"github.com/scaleway/scaleway-cli/pkg/api"
+	"github.com/scaleway/scaleway-cli/pkg/utils"
+)
+
+// LogsArgs are flags for the `RunLogs` function
+type LogsArgs struct {
+	Gateway string
+	Server  string
+}
+
+// RunLogs is the handler for 'scw logs'
+func RunLogs(ctx CommandContext, args LogsArgs) error {
+	serverID := ctx.API.GetServerID(args.Server)
+	server, err := ctx.API.GetServer(serverID)
+	if err != nil {
+		return fmt.Errorf("failed to get server information for %s: %v", serverID, err)
+	}
+
+	// FIXME: switch to serial history when API is ready
+
+	// Resolve gateway
+	if args.Gateway == "" {
+		args.Gateway = ctx.Getenv("SCW_GATEWAY")
+	}
+	var gateway string
+	if args.Gateway == serverID || args.Gateway == args.Server {
+		gateway = ""
+	} else {
+		gateway, err = api.ResolveGateway(ctx.API, args.Gateway)
+		if err != nil {
+			return fmt.Errorf("cannot resolve Gateway '%s': %v", args.Gateway, err)
+		}
+	}
+
+	command := []string{"dmesg"}
+	err = utils.SSHExec(server.PublicAddress.IP, server.PrivateIP, command, true, gateway)
+	if err != nil {
+		return fmt.Errorf("command execution failed: %v", err)
+	}
+	return nil
+}