Skip to content

Commit 537d396

Browse files
s-rigaudSamuel Rigaud
and
Samuel Rigaud
authored
GLTFLoader: fix bad reference to PATH_PROPERTIES (#30669)
Co-authored-by: Samuel Rigaud <[email protected]>
1 parent 4e441e8 commit 537d396

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Diff for: examples/jsm/loaders/GLTFLoader.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -2295,7 +2295,7 @@ function addUnknownExtensionsToUserData( knownExtensions, object, objectDef ) {
22952295
}
22962296

22972297
/**
2298-
* @param {Object3D|Material|BufferGeometry} object
2298+
* @param {Object3D|Material|BufferGeometry|Object} object
22992299
* @param {GLTF.definition} gltfDef
23002300
*/
23012301
function assignExtrasToUserData( object, gltfDef ) {
@@ -3355,7 +3355,7 @@ class GLTFParser {
33553355
* @param {Object} materialParams
33563356
* @param {string} mapName
33573357
* @param {Object} mapDef
3358-
* @param {string} colorSpace
3358+
* @param {string} [colorSpace]
33593359
* @return {Promise<Texture>}
33603360
*/
33613361
assignTexture( materialParams, mapName, mapDef, colorSpace ) {
@@ -3761,7 +3761,7 @@ class GLTFParser {
37613761
/**
37623762
* Specification: https://github.com/KhronosGroup/glTF/blob/master/specification/2.0/README.md#meshes
37633763
* @param {number} meshIndex
3764-
* @return {Promise<Group|Mesh|SkinnedMesh>}
3764+
* @return {Promise<Group|Mesh|SkinnedMesh|Line|Points>}
37653765
*/
37663766
loadMesh( meshIndex ) {
37673767

@@ -4463,7 +4463,7 @@ class GLTFParser {
44634463
TypedKeyframeTrack = QuaternionKeyframeTrack;
44644464
break;
44654465

4466-
case PATH_PROPERTIES.position:
4466+
case PATH_PROPERTIES.translation:
44674467
case PATH_PROPERTIES.scale:
44684468

44694469
TypedKeyframeTrack = VectorKeyframeTrack;

0 commit comments

Comments
 (0)