From fdb1dc68761d4e4d00602f2ff4c748137369c088 Mon Sep 17 00:00:00 2001 From: Mugen87 Date: Tue, 11 Mar 2025 13:40:44 +0100 Subject: [PATCH 1/2] LUTImageLoader: Harmonize ctor. --- examples/jsm/loaders/LUTImageLoader.js | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/examples/jsm/loaders/LUTImageLoader.js b/examples/jsm/loaders/LUTImageLoader.js index 8034d524179056..42d8f705908587 100644 --- a/examples/jsm/loaders/LUTImageLoader.js +++ b/examples/jsm/loaders/LUTImageLoader.js @@ -23,22 +23,23 @@ export class LUTImageLoader extends Loader { /** * Constructs a new LUT loader. * - * @param {boolean} [flipVertical=false] - Whether to vertically flip the LUT or not. + * @param {LoadingManager} [manager] - The loading manager. */ - constructor( flipVertical = false ) { + constructor( manager ) { - //The NeutralLUT.png has green at the bottom for Unreal ang green at the top for Unity URP Color Lookup - //post-processing. If you're using lut image strips from a Unity pipeline then pass true to the constructor - - super(); + super( manager ); /** * Whether to vertically flip the LUT or not. * + * Depending on the LUT's orogin, the texture has green at the bottom (e.g. for Unreal) + * and green at the top (e.g. for Unity URP Color Lookup). If you're using lut image strips + * from a Unity pipeline then set this property to `true`. + * * @type {boolean} * @default false */ - this.flip = flipVertical; + this.flip = false; } From 9726f1895c0e1d966092446e5861f45e1a29af2d Mon Sep 17 00:00:00 2001 From: Michael Herzog Date: Tue, 11 Mar 2025 13:43:14 +0100 Subject: [PATCH 2/2] Update LUTImageLoader.js Fix typos. --- examples/jsm/loaders/LUTImageLoader.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/jsm/loaders/LUTImageLoader.js b/examples/jsm/loaders/LUTImageLoader.js index 42d8f705908587..54aede444e464f 100644 --- a/examples/jsm/loaders/LUTImageLoader.js +++ b/examples/jsm/loaders/LUTImageLoader.js @@ -32,9 +32,9 @@ export class LUTImageLoader extends Loader { /** * Whether to vertically flip the LUT or not. * - * Depending on the LUT's orogin, the texture has green at the bottom (e.g. for Unreal) - * and green at the top (e.g. for Unity URP Color Lookup). If you're using lut image strips - * from a Unity pipeline then set this property to `true`. + * Depending on the LUT's origin, the texture has green at the bottom (e.g. for Unreal) + * or green at the top (e.g. for Unity URP Color Lookup). If you're using lut image strips + * from a Unity pipeline, then set this property to `true`. * * @type {boolean} * @default false