Skip to content

[BUG] Excessive file access when using Samba #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xachb opened this issue Apr 16, 2024 · 3 comments
Open

[BUG] Excessive file access when using Samba #484

xachb opened this issue Apr 16, 2024 · 3 comments
Labels

Comments

@xachb
Copy link

xachb commented Apr 16, 2024

The bug
When using xvlog on windows, and accessing files on Red Hat sever over a Samba, I am pegging the remote servers CPU.

Environment:

  • Local OS: Windows 10 Enterprise 22H2 build 19045.4170
  • Server OS: Red Hat Enterprise Linux Server release 7.9 (Maipo)
  • VS Code version: 1.88.1
  • Extension version: 1.13.5
  • Lint tools: xvlog (Vivado 2020.2 on local windows machine) linting

Steps to reproduce
Steps to reproduce the behavior:

  1. Enable Verilog-HDL/SystemVerilog/Bluespec SystemVerilog extension (with xvlog linter running on windows machine)
  2. Run top on my linux server (watch CPU utilization for smbd process peg around 65-95% of cpu useage), file access is slow and sometimes unresponsive
  3. Disable extension (watch smdb utilization drop to nothing)

Expected behavior
I would expect reasonable file access with this extension, all of my other extensions in vscode are doing just fine.

Actual behavior
Blowing up Samba on Red Hat server. Is it possible that the linter is running at the file location, and not in the local workspace?

I really appreciate this linter, but unfortunately, I have to disable it in my environment because it is breaking our remote server, I hope you can find a fix.

Thank you,
Zach

@xachb xachb added the bug label Apr 16, 2024
@defvs
Copy link

defvs commented Apr 9, 2025

The issue is that the extension triggers a #find command which leads to ripgrep doing a project-wide search. That causes massive headaches when the filesystem is slow, such as on SMB.

@defvs
Copy link

defvs commented Apr 9, 2025

I dug more into this - on my side, this is caused by a full project search triggered when hovering a symbol :

let matches: vscode.DefinitionLink[] = await this.ctagsManager.findSymbol(document, position);

which leads to a search for **/${symbol}.sv:

let searchPattern = new vscode.RelativePattern(vscode.workspace.workspaceFolders[0], `**/${moduleToFind}.sv`);

If these take a lot of time to finish, they start to pile up and bog the CPU and Filesystem down.

@

@defvs
Copy link

defvs commented Apr 9, 2025

A temporary fix would be to disable hovering, by adding this to your settings.json:

    "[systemverilog]": {
        "editor.hover.enabled": false
    },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants