Skip to content

Commit 18f7376

Browse files
authored
Merge pull request #23 from helloextend/update-naming-on-starter
Updating naming and error handling
2 parents 07cce8e + 5e8550a commit 18f7376

File tree

6 files changed

+40
-29
lines changed

6 files changed

+40
-29
lines changed

Diff for: package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"jest": "^24.9.0",
1515
"lambda-local": "^1.6.3",
1616
"node-fetch": "^2.6.1",
17-
"prettier": "^1.18.2",
17+
"prettier": "2.1.1",
1818
"ts-jest": "^24.1.0",
1919
"typescript": "^3.6.4"
2020
},
@@ -25,7 +25,7 @@
2525
"build": "tsc",
2626
"lint": "eslint --ext=.ts src",
2727
"test": "jest",
28-
"test:lambda": "yarn build && lambda-local -l ./dist/index.js -e ./dist/mock-events/default -h stuffGet"
28+
"test:lambda": "yarn build && lambda-local -l ./dist/index.js -e ./dist/mock-events/default -h randomGet"
2929
},
3030
"version": "1.0.0"
3131
}

Diff for: src/lambdas/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
export { handler as stuffGet } from './stuff-get'
1+
export { handler as randomGet } from './random-get'

Diff for: src/lambdas/stuff-get.test.ts renamed to src/lambdas/random-get.test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import fetch from 'node-fetch'
2-
import { handler } from './stuff-get'
2+
import { handler } from './random-get'
33

44
const mockedFetch: jest.Mock = fetch as any
55

66
jest.mock('node-fetch')
77

8-
describe('stuff-get handler', () => {
8+
describe('random-get handler', () => {
99
const mockPayload = { test: 'hello?' }
1010
beforeEach(() => {
1111
mockedFetch.mockReturnValueOnce({

Diff for: src/lambdas/random-get.ts

+31
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
import fetch from 'node-fetch'
2+
import { Response } from './types'
3+
4+
interface RandomResponse extends Response {
5+
body: RandomDog
6+
}
7+
8+
interface ErrorResponse extends Response {
9+
message: string
10+
}
11+
12+
interface RandomDog {
13+
message: string
14+
status: string
15+
}
16+
17+
export async function handler(): Promise<RandomResponse | ErrorResponse> {
18+
try {
19+
const res = await fetch('https://dog.ceo/api/breeds/image/random')
20+
const payload: RandomDog = await res.json()
21+
return {
22+
statusCode: 200,
23+
body: payload,
24+
}
25+
} catch (err: unknown) {
26+
return {
27+
statusCode: 500,
28+
message: 'Something went wrong',
29+
}
30+
}
31+
}

Diff for: src/lambdas/stuff-get.ts

-20
This file was deleted.

Diff for: yarn.lock

+4-4
Original file line numberDiff line numberDiff line change
@@ -3393,10 +3393,10 @@ prettier-linter-helpers@^1.0.0:
33933393
dependencies:
33943394
fast-diff "^1.1.2"
33953395

3396-
prettier@^1.18.2:
3397-
version "1.18.2"
3398-
resolved "https://registry.yarnpkg.com/prettier/-/prettier-1.18.2.tgz#6823e7c5900017b4bd3acf46fe9ac4b4d7bda9ea"
3399-
integrity sha512-OeHeMc0JhFE9idD4ZdtNibzY0+TPHSpSSb9h8FqtP+YnoZZ1sl8Vc9b1sasjfymH3SonAF4QcA2+mzHPhMvIiw==
3396+
prettier@2.1.1:
3397+
version "2.1.1"
3398+
resolved "https://extend-159581800400.d.codeartifact.us-east-1.amazonaws.com:443/npm/extend-npm/prettier/-/prettier-2.1.1.tgz#d9485dd5e499daa6cb547023b87a6cf51bee37d6"
3399+
integrity sha512-9bY+5ZWCfqj3ghYBLxApy2zf6m+NJo5GzmLTpr9FsApsfjriNnS2dahWReHMi7qNPhhHl9SYHJs2cHZLgexNIw==
34003400

34013401
pretty-format@^24.9.0:
34023402
version "24.9.0"

0 commit comments

Comments
 (0)