Skip to content

Commit 5bdfadf

Browse files
jeremyd2019lazka
authored andcommitted
handle ncursesw pkg-config when cross-compiling
strip extra args from pkg-config --cflags-only-I, setup.py is only expecting a single path. Use pkg-config ncursesw include dir even if cross-compiling (PKG_CONFIG_PATH should be set in that case).
1 parent 1788516 commit 5bdfadf

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

configure.ac

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3868,7 +3868,7 @@ else
38683868
fi
38693869

38703870
if test "$with_system_ffi" = "yes" && test -n "$PKG_CONFIG"; then
3871-
LIBFFI_INCLUDEDIR="`"$PKG_CONFIG" libffi --cflags-only-I 2>/dev/null | sed -e 's/^-I//;s/ *$//'`"
3871+
LIBFFI_INCLUDEDIR="`"$PKG_CONFIG" libffi --cflags-only-I 2>/dev/null | sed -e 's/^-I//;s/ .*$//'`"
38723872
else
38733873
LIBFFI_INCLUDEDIR=""
38743874
fi
@@ -6439,17 +6439,15 @@ then
64396439
fi
64406440

64416441
if test -n "$PKG_CONFIG"; then
6442-
NCURSESW_INCLUDEDIR="`"$PKG_CONFIG" ncursesw --cflags-only-I 2>/dev/null | sed -e 's/^-I//;s/ *$//'`"
6442+
NCURSESW_INCLUDEDIR="`"$PKG_CONFIG" ncursesw --cflags-only-I 2>/dev/null | sed -e 's/^-I//;s/ .*$//'`"
64436443
else
64446444
NCURSESW_INCLUDEDIR=""
64456445
fi
64466446
AC_SUBST(NCURSESW_INCLUDEDIR)
64476447

64486448
# first curses header check
64496449
ac_save_cppflags="$CPPFLAGS"
6450-
if test "$cross_compiling" = no; then
6451-
CPPFLAGS="$CPPFLAGS -I$NCURSESW_INCLUDEDIR"
6452-
fi
6450+
CPPFLAGS="$CPPFLAGS -I$NCURSESW_INCLUDEDIR"
64536451

64546452
AC_CHECK_HEADERS(curses.h ncurses.h)
64556453

setup.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1155,8 +1155,7 @@ def detect_readline_curses(self):
11551155
panel_library = 'panel'
11561156
if curses_library == 'ncursesw':
11571157
curses_defines.append(('HAVE_NCURSESW', '1'))
1158-
if not CROSS_COMPILING:
1159-
curses_includes.append(sysconfig.get_config_var("NCURSESW_INCLUDEDIR"))
1158+
curses_includes.append(sysconfig.get_config_var("NCURSESW_INCLUDEDIR"))
11601159
# Bug 1464056: If _curses.so links with ncursesw,
11611160
# _curses_panel.so must link with panelw.
11621161
panel_library = 'panelw'

0 commit comments

Comments
 (0)